From: Robert Williamson <robbiew@us...> - 2002-06-10 17:50:17
I applied this patch and made some corrections to it as well. The #defines
needed to be typecasted to "mode_t" types in order for the comparisons to
work correctly, i.e.
if (PERMS != dir_mode)
would not function correctly until I added the typecasting. This was
probably why the initial test used the octal numbers...but this way is
better. I also modified 'fchmod05' to act accordingly..but it doesn't look
as "pretty" as Jay's ;P. Now both tests function correctly and have been
checked into CVS for the July release.
Robert V. Williamson <robbiew@...>
Linux Test Project
IBM Linux Technology Center
Phone: (512) 838-9295 T/L: 638-9295
Huie/Poughkeepsie/IBM@... To: ltp-list@...
Sent by: Subject: [LTP] Re: [Ltp-results] s390 LTP-20020507 : Pass 96.50 % : 579
ltp-list-admin@... succeeded : 21 failed
06/06/2002 03:35 PM
>The "-f" flag turns OFF functionality testing...that is why it's not used
The problem is that since there's a '-f' in the automation files then
that becomes the default.
I think you're right Robbie, that it tails w/o the -f so that's why
it's there and thus why noone's fixed them.
I'm going to try to make this a focus of my team as part of their
first LTP work so hopefully we can remedy this.
My chmod05 patch fixes chmod05's -f (w/o removing it) option as well as the
helper script it uses. I am sorry that I did change the formatting but do
the patch and run a diff -b -B and you shouldn't see much except the real
changes, and I promise next time to not make it easier on myself.
(See attached file: chmod05_cleanups.patch)
zSeries Linux System Test
#### chmod05_cleanups.patch has been removed from this note on June 10 2002
by Robert Williamson