On Mon, Jun 16, 2008 at 3:41 PM, Masatake YAMATO <yamato@redhat.com> wrote:
> Oh Yes. You are correct. I did not look in to that aspect at all. I just did
> a comparison of whatever we have at *testcases/kernel/syscalls* and what
> they have in *Crackerjack*. I am listing down my comments here:

O.k. I'll focus on *testcases/kernel/syscalls*. So the porting task becomes
much simpler.

> 91) lstat64
> Comments: We have lstat at *testcases/kernel/syscalls/lstat**. *You may need
> to include/port lstat64 on similar lines to sendfile64 and fadvise64.
>
> 92) setfsuid16
> Comments: We have setfsuid at *testcases/kernel/syscalls/setfsuid**. *You
> may need to include/port setfsuid16 on similar lines to sendfile64 and
> fadvise64.


Really grate list.

Thanks. We will keep this as a standard one to review our progress against what is done and what still needs to be done.



BTW,

> 92) setfsuid16
> Comments: We have setfsuid at *testcases/kernel/syscalls/setfsuid**. *You
> may need to include/port setfsuid16 on similar lines to sendfile64 and
> fadvise64.

You wrote "sendfile64 and fadvise64".
I think you mean setfsuid instead, don't you?

I coundn't understand why you wrote "sendfile64 and fadvise64" here.

Oh yes. What i actually wanted to mean is, you can port setfsuid16 from Crackerjack to LTP, in the same way you have done for sendfile64 and fadvise64 earlier. You can either include the code from CrackerjackÅ› setfsuid16 into ltp/testcases/kernel/syscalls/setfsuid/setfsuid*.c, or, you can have them as seperate directory as ltp/testcases/kernel/syscalls/setfsuid16. This can be the way for all the 16-bit and 64-bit versions of the syscalls available in Crackerjack.

Regards--
Subrata



Masatake



--
Regards & Thanks--
Subrata