From: Florian J. <flo...@we...> - 2013-05-19 20:41:40
Attachments:
signature.asc
|
Hi moving to git is a good opportunity for altering history. Would you like me to fix the indentation of all .cpp and .h files by piping it through indent or some similar program? this will affect all commits, also those in the past. While this obviously means changing history, it does not involve one large "coding style" commit which would break diff-ing revisions. In my opinion, the indentation is pretty insane, but of course I'll wait for your agreement :) how about only indenting with tabs, and coding style like this: int function() { stuff; goes(); if (some && condition) { foo(); } return here; } ? greetings, flo |
From: Florian J. <flo...@we...> - 2013-05-19 20:50:17
Attachments:
signature.asc
|
Oh and an addition: do you wish to have the muse2/ directory removed as well? So files reside under ./file.c instead of ./muse2/file.c? greetings Am 19.05.2013 22:41, schrieb Florian Jung: > Hi > > moving to git is a good opportunity for altering history. Would you like > me to fix the indentation of all .cpp and .h files by piping it through > indent or some similar program? > > this will affect all commits, also those in the past. While this > obviously means changing history, it does not involve one large "coding > style" commit which would break diff-ing revisions. > > > In my opinion, the indentation is pretty insane, but of course I'll wait > for your agreement :) > > > how about only indenting with tabs, and coding style like this: > > int function() { > stuff; > goes(); > if (some && condition) { > foo(); > } > return here; > } > > ? > > greetings, > flo > > > > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > > > > _______________________________________________ > Lmuse-developer mailing list > Lmu...@li... > https://lists.sourceforge.net/lists/listinfo/lmuse-developer |
From: Robert J. <spa...@gm...> - 2013-05-19 20:52:50
|
Hi, 2013/5/19 Florian Jung <flo...@we...> > Hi > > moving to git is a good opportunity for altering history. Would you like > me to fix the indentation of all .cpp and .h files by piping it through > indent or some similar program? > > this will affect all commits, also those in the past. While this > obviously means changing history, it does not involve one large "coding > style" commit which would break diff-ing revisions. > > > In my opinion, the indentation is pretty insane, but of course I'll wait > for your agreement :) > > > how about only indenting with tabs, and coding style like this: > > int function() { > stuff; > goes(); > if (some && condition) { > foo(); > } > return here; > } > > ? > I really dislike the BSD-style code so I'm not against removing that but making automatic changes have not worked that well for me in the past... Not sure what you mean by "changing history"? Would we be able to keep the history and invisibly change the indentation? Sounds like magic ;) Tim has coded lots more of the code so his word is heavier than mine, by far :) Regards, Robert > greetings, > flo > > |
From: Florian J. <flo...@we...> - 2013-05-19 21:30:27
Attachments:
signature.asc
|
Am 19.05.2013 22:52, schrieb Robert Jonsson: > Hi, > > > 2013/5/19 Florian Jung <flo...@we...> > >> Hi >> >> moving to git is a good opportunity for altering history. Would you like >> me to fix the indentation of all .cpp and .h files by piping it through >> indent or some similar program? >> >> this will affect all commits, also those in the past. While this >> obviously means changing history, it does not involve one large "coding >> style" commit which would break diff-ing revisions. >> >> >> In my opinion, the indentation is pretty insane, but of course I'll wait >> for your agreement :) >> >> >> how about only indenting with tabs, and coding style like this: >> >> int function() { >> stuff; >> goes(); >> if (some && condition) { >> foo(); >> } >> return here; >> } >> >> ? >> > > I really dislike the BSD-style code so I'm not against removing that but > making automatic changes have not worked that well for me in the past... first, this is GNU indent, so we can use whatever options this tool supports. kdevelop's indenting feature would really rock, but i guess this cannot be called on the CLI. > > Not sure what you mean by "changing history"? Would we be able to keep the > history and invisibly change the indentation? > Sounds like magic ;) git is a bit of magic :) "changing history" means: 1) i convert svn to git, and have the weird indentation 2) i run a tool that takes every commit, runs a program (in this case, indent) on this commit, and replaces the original commit with the result of this progra,. 3) now, the "old" history with strange indentation is lost. > > Tim has coded lots more of the code so his word is heavier than mine, by > far :) of course. As indentation is a matter of taste, i don't want to do anything without asking you first :) Tim? greetings flo > > Regards, > Robert > > >> greetings, >> flo >> >> > |
From: Florian J. <flo...@we...> - 2013-05-19 21:58:27
Attachments:
signature.asc
|
oookay, i've fiddled with this now: due to the muse2, muse, muse2-evolution branches which lived under trunk/ and not under branches/, git-svn hasn't correctly recognized them as "branches" this is not really a problem, as we won't lose any code or information just these directories show up as *directories* under git, not as branches (a distinction which hasn't even existed under svn) i can offer the following "beautifications": - reindent all code to some style you prefer, using whatever (command line) tool you prefer - put everything under muse2/ into the root of the repo, and remove the muse2 directory - everything else which can be expressed as a script which operates on files. i only can apply them on commits after the "clean3" commit, which roughly happened when i also joined the team. That would be ~2 years ago. if you want me to do these beautifications, be aware that they break diff-ing over the border of the clean3-commit! this means: you can compare everything which happened within the last 2 years. you can compare everything which happened before the last 2 years you CANNOT compare stuff which happeed within the last 2 years with stuff which happened before. i don't consider that a problem. this is not even a suggestion, I just want you to know that it is possible, and if you wish this, *now* is the time to do it. we'll probably never again get the opportunity for such history changes. if you don't want, there you go ;) greetings flo |
From: Tim E. R. <ter...@ro...> - 2013-05-20 00:41:00
|
On May 19, 2013 11:30:16 PM Florian Jung wrote: > of course. As indentation is a matter of taste, i don't want to do > anything without asking you first :) > Tim? Dudes, I'm { an; ANSI; coder; } For blocks longer than say, 20 lines or so, I demand brackets that line up. For me it's essential for quick bracket accounting. Anything less than 20 lines or so { I don't care too much; } and() {I do try to compact as much as possible these days; } And I do not use tabs. I don't mind if someone is modifying my code for the sake of repairs (I do it sometimes) because it may be essential for the person to be able to understand the code and work in their own comfort zone. I don't care, next time I'm in there I'll just change it again. But mostly I try to respect others' styles when modifying esp. tabs. Is it really necessary to beautify the whole app right NOW? And eliminating the ./muse2 folder? Hm that might make generating diffs harder for my branches that still need tending to. I guess if you have to, but... is it a wise idea right now? Tim. |
From: Orcan O. <oge...@gm...> - 2013-05-20 03:09:05
|
Hi brethren! On Sun, May 19, 2013 at 8:40 PM, Tim E. Real wrote: > On May 19, 2013 11:30:16 PM Florian Jung wrote: >> of course. As indentation is a matter of taste, i don't want to do >> anything without asking you first :) >> Tim? > > Dudes, I'm > { > an; > ANSI; > coder; > } > > For blocks longer than say, 20 lines or so, I demand brackets > that line up. For me it's essential for quick bracket accounting. > > Anything less than 20 lines or so { > I don't care too much; } > > and() {I do try to compact as much as possible these days; } > > And I do not use tabs. > > I don't mind if someone is modifying my code for the sake of repairs > (I do it sometimes) because it may be essential for the person to be > able to understand the code and work in their own comfort zone. > I don't care, next time I'm in there I'll just change it again. > But mostly I try to respect others' styles when modifying esp. tabs. > > Is it really necessary to beautify the whole app right NOW? > > And eliminating the ./muse2 folder? > Hm that might make generating diffs harder for my branches > that still need tending to. > I guess if you have to, but... is it a wise idea right now? > Not that I do real coding (real, meaning for Muse or other freedom projects ;)) these days, but I just wanted to say that I agree 100% with Tim, not even 99%. Before you ask, I am doing good. We have a new family member at home (say hi to Albert!). I am trying to find time to read emails, to play my guitar and to sleep, of course. Cheers, Orcan |
From: Tim E. R. <ter...@ro...> - 2013-05-20 17:44:31
|
On May 19, 2013 11:08:35 PM Orcan Ogetbil wrote: > Hi brethren! > > On Sun, May 19, 2013 at 8:40 PM, Tim E. Real wrote: > > On May 19, 2013 11:30:16 PM Florian Jung wrote: > >> of course. As indentation is a matter of taste, i don't want to do > >> anything without asking you first :) > >> Tim? > > > > Dudes, I'm > > { > > > > an; > > ANSI; > > coder; > > > > } > > > > For blocks longer than say, 20 lines or so, I demand brackets > > > > that line up. For me it's essential for quick bracket accounting. > > > > Anything less than 20 lines or so { > > > > I don't care too much; } > > > > and() {I do try to compact as much as possible these days; } > > > > And I do not use tabs. > > > > I don't mind if someone is modifying my code for the sake of repairs > > > > (I do it sometimes) because it may be essential for the person to be > > able to understand the code and work in their own comfort zone. > > > > I don't care, next time I'm in there I'll just change it again. > > But mostly I try to respect others' styles when modifying esp. tabs. > > > > Is it really necessary to beautify the whole app right NOW? > > > > And eliminating the ./muse2 folder? > > Hm that might make generating diffs harder for my branches > > > > that still need tending to. > > > > I guess if you have to, but... is it a wise idea right now? > Hello Orcan! > Not that I do real coding (real, meaning for Muse or other freedom > projects ;)) these days, but I just wanted to say that I agree 100% > with Tim, not even 99%. Er, about coding... ahem... 'style' ? Ah well, it's just personal taste - I learned from Mr. Borland's manuals ! > Before you ask, I am doing good. We have a new family member at home > (say hi to Albert!). Hey awesome! Who's the genius? Well, hello Albert ! He he... > I am trying to find time to read emails, to play > my guitar and to sleep, of course. Hey we share the same goals. 'Specially that [yawn] sleep thing... I should be recording material but so many delays... BTW what guitar(s) do you have? And do you have an amp or do you use software (Guitarix etc) and a regular stereo? -------- Just a heads up for those reading this: I'm fixing some long-time stupid midi stuff in MusE. Like for example... Having to rec-arm a midi track just to hear anything coming in. Too much midi-out traffic when adjusting (N)RPN controls. Can't say too much more for fear of jinxing it, but I'm also working on finally getting MusE to accept hi-res controller input (RPN etc.), and finally adding midi automation to the strips, just like audio strips. And much more. Should be soon for some of this stuff... Wish me luck. Tim. > > Cheers, > Orcan > |
From: Dennis S. <mus...@wi...> - 2013-05-20 18:58:36
|
On Mon, 20 May 2013 13:44:10 -0400 "Tim E. Real" <ter...@ro...> wrote: > Just a heads up for those reading this: > I'm fixing some long-time stupid midi stuff in MusE. > Like for example... > Having to rec-arm a midi track just to hear anything coming in. > Too much midi-out traffic when adjusting (N)RPN controls. > > Can't say too much more for fear of jinxing it, but I'm also working > on finally getting MusE to accept hi-res controller input (RPN etc.), > and finally adding midi automation to the strips, just like audio strips. > And much more. Should be soon for some of this stuff... Wish me luck. Sounds awesome. Can't wait to try out. :o) Dennis |
From: Orcan O. <oge...@gm...> - 2013-05-22 03:14:49
|
On Mon, May 20, 2013 at 1:44 PM, Tim E. Real wrote: > On May 19, 2013 11:08:35 PM Orcan Ogetbil wrote: > Hello Orcan! Hi! > > Er, about coding... ahem... 'style' ? > Ah well, it's just personal taste - I learned from Mr. Borland's manuals ! > My taste is concise() { return membervariable_; } // for very short function bodies e.g. inside header files in class definitions, // (I also like to designate the member variables, e.g. with underscores as above) for(;;) { long blocks; and(); //of course no_tabs(); } while(short_blocks()) can_be(one, or, two, lines, without, curly, brackets); >> Before you ask, I am doing good. We have a new family member at home >> (say hi to Albert!). > > Hey awesome! Who's the genius? Well, hello Albert ! He he... > Hehe! Can one tell his dad was physicist? > > BTW what guitar(s) do you have? And do you have an amp or > do you use software (Guitarix etc) and a regular stereo? > I have a Strat, recently customized with a Warmoth neck. Man... Warmoth necks are so much better than original Fenders! Last month I added a 7-string Music Man to the collection and I am learning how to play this beast :) Ampwise, I don't have anything fancy yet. I fell in love with the Mesa Boogie that I tried at the Guitar Center. But our relationship got suspended when I saw the price tag :( Maybe one day... Otherwise I have an old but decent Boss processor that I can plug-in to the sound card to record stuff. I also play with guitarix from time to time. I was playing bass in a start-up band for the last few months. We wrote some cool stuff. Unfortunately, the guitarist had to move away for work. Now we have to start over with another guitarist (or bassist). Peace, Orcan |
From: Tim E. R. <ter...@ro...> - 2013-05-22 09:19:52
|
On May 21, 2013 11:14:17 PM Orcan Ogetbil wrote: > I have a Strat, recently customized with a Warmoth neck. Man... > Warmoth necks are so much better than original Fenders! How so? The wood or the frets? > Last month I added a 7-string Music Man to the collection and I am > learning how to play this beast :) I repaired an Ibanez 7-string for someone which just wouldn't stay in tune (has a floating bridge). So I got to try it out. Many bolts/screws were loose, and that 7th string is sooo sensitive to the slightest changes which tends to throw out the other strings. (Leading to Bridge Balancing Hell). Later I saw the guy play a gig with it, he said it was great and stayed in tune. I was amazed it did. > Ampwise, I don't have anything fancy yet. I fell in love with the Mesa > Boogie that I tried at the Guitar Center. But our relationship got > suspended when I saw the price tag :( Maybe one day... He, yeah, just friends for now eh? Mine is Marshall JCM800. Line6 seems to be all the rage today. Tried a few of them, and friends traded in their Marshalls for them. > Otherwise I have an old but decent Boss processor that I can plug-in > to the sound card to record stuff. I also play with guitarix from time > to time. I have BOSS SE-70 Super Effects processor, rack mount. Also a very cool ME-10 Multi Effects floor unit with pedals which has a touch overlay where all of the units parameters are in front of you at once. Guitarix is (one of) the coolest Linux guitar app. ----------------- Guitarists: Do you have a regular midi foot controller to change midi patches? Are you tired of having to set up different midi patches on your effects unit so that you can switch them using the controller just so you can get different stored sounds? Do you wish that rather than just midi patch changers, the foot controllers would act as true effect on/off foot toggle switches (like my BOSS ME-10), just like an old fashioned pedal board? Or, can your foot controller send out toggled configurable midi controller messages, and you'd like MusE to use them? For the longest time I've had a plan to *toggle* MusE rack effects 'Bypass' on or off upon reception of a user-chosen *patch* (program) or controller midi message. Similar to what our Midi Transformator plugin can do - how it intercepts and modifies messages in wild and wacky ways. First though, I need to add effect bypass controllers - something I've tried many times to finally realize but it's tough due to ID number placement issues. Someday I'm gonna finish it. ----------------- > I was playing bass in a start-up band for the last few months. We > wrote some cool stuff. Unfortunately, the guitarist had to move away > for work. Now we have to start over with another guitarist (or > bassist). Ah too bad, if you lived nearby we could jam. Tim. > > Peace, > Orcan > |
From: Dennis S. <mus...@wi...> - 2013-05-22 19:28:55
|
On Wed, 22 May 2013 05:19:36 -0400 "Tim E. Real" <ter...@ro...> wrote: > ----------------- > Guitarists: Do you have a regular midi foot controller to change midi patches? > Are you tired of having to set up different midi patches on your effects unit > so that you can switch them using the controller just so you can get different > stored sounds? > Do you wish that rather than just midi patch changers, the foot controllers > would act as true effect on/off foot toggle switches (like my BOSS ME-10), > just like an old fashioned pedal board? I have Yamaha MFC-10 which can send any cc, note on or note off but use it for keyboards only. I'm much more a keyboard player and only casual guitarist. For fx I use a Boss GX-700 rack unit and a Fender Mustang Floor pedal. Both a great devices. > For the longest time I've had a plan to *toggle* MusE rack effects 'Bypass' > on or off upon reception of a user-chosen *patch* (program) or controller > midi message. I love that idea. Dennis |
From: Robert J. <spa...@gm...> - 2013-05-20 19:21:30
|
2013/5/20 Tim E. Real <ter...@ro...> > On May 19, 2013 11:08:35 PM Orcan Ogetbil wrote: > > Hi brethren! > > > > On Sun, May 19, 2013 at 8:40 PM, Tim E. Real wrote: > > > On May 19, 2013 11:30:16 PM Florian Jung wrote: > > >> of course. As indentation is a matter of taste, i don't want to do > > >> anything without asking you first :) > > >> Tim? > > > > > > Dudes, I'm > > > { > > > > > > an; > > > ANSI; > > > coder; > > > > > > } > > > > > > For blocks longer than say, 20 lines or so, I demand brackets > > > > > > that line up. For me it's essential for quick bracket accounting. > > > > > > Anything less than 20 lines or so { > > > > > > I don't care too much; } > > > > > > and() {I do try to compact as much as possible these days; } > > > > > > And I do not use tabs. > > > > > > I don't mind if someone is modifying my code for the sake of repairs > > > > > > (I do it sometimes) because it may be essential for the person to be > > > able to understand the code and work in their own comfort zone. > > > > > > I don't care, next time I'm in there I'll just change it again. > > > But mostly I try to respect others' styles when modifying esp. tabs. > > > > > > Is it really necessary to beautify the whole app right NOW? > > > > > > And eliminating the ./muse2 folder? > > > Hm that might make generating diffs harder for my branches > > > > > > that still need tending to. > > > > > > I guess if you have to, but... is it a wise idea right now? > > > > Hello Orcan! > Yeah, hey man! Glad to see you around :) > > Not that I do real coding (real, meaning for Muse or other freedom > > projects ;)) these days, but I just wanted to say that I agree 100% > > with Tim, not even 99%. > I don't mind that much, except the BSD style. Thinking about it I think we shouldn't try to automatically change it. I'm thinking it could do just as much damage as good.. > > Er, about coding... ahem... 'style' ? > Ah well, it's just personal taste - I learned from Mr. Borland's manuals ! > > > Before you ask, I am doing good. We have a new family member at home > > (say hi to Albert!). > > Hey awesome! Who's the genius? Well, hello Albert ! He he... > Hey ya! > > > I am trying to find time to read emails, to play > > my guitar and to sleep, of course. > > Hey we share the same goals. 'Specially that [yawn] sleep thing... > > I should be recording material but so many delays... > > BTW what guitar(s) do you have? And do you have an amp or > do you use software (Guitarix etc) and a regular stereo? > > -------- > Just a heads up for those reading this: > I'm fixing some long-time stupid midi stuff in MusE. > Like for example... > Having to rec-arm a midi track just to hear anything coming in. > Too much midi-out traffic when adjusting (N)RPN controls. > > Can't say too much more for fear of jinxing it, but I'm also working > on finally getting MusE to accept hi-res controller input (RPN etc.), > and finally adding midi automation to the strips, just like audio strips. > And much more. Should be soon for some of this stuff... Wish me luck. > Knock on wood! Sounds good Tim, just don't work yourself into an early grave :) Regards, Robert |
From: Florian J. <flo...@we...> - 2013-05-21 20:00:15
Attachments:
signature.asc
|
Am 20.05.2013 21:21, schrieb Robert Jonsson: > 2013/5/20 Tim E. Real <ter...@ro...> >>>> Is it really necessary to beautify the whole app right NOW? not neccessary. But when you re-format code whenever you stumble upon some weird-formatted place, then you break diff-ing across this commit. re-formatting it now would allow us to manipulate older commits as well, resulting in a nicely diffable history. but there's no real need to do it. >>>> And eliminating the ./muse2 folder? >>>> Hm that might make generating diffs harder for my branches >>>> that still need tending to. true, that was a bad idea. greetings, flo |