Re: [Linuxwacom-devel] [PATCH 5/7] Decrease minimum number of args to 'set' [allow wheels/strips "reset"]

[Peter H. <pet...@wh...>]

On Wed, Mar 30, 2011 at 01:54:45PM -0700, Jason Gerecke wrote:
> Since the worker functions now check that they have the appropriate
> number of arguments, its possible to decrease the number of arguments
> required by 'set'. Since all it really needs is a device number and
> a property, the minimum argc is now 2.
> 
> A handy side-effect of this change is that its now possible to run
> e.g. `xsetwacom --set $ID StripLeftDown` to reset the action to
> its default. 

is that because we delete the property then so it falls back to using the
button mapping?

this formulation is a bit unfortunate, since it doesn't actually set to the
default. if I map the button to say 8, then run the above command it would
revert back to 8, not to the default (4 or whatever it is), right?

Cheers,
  Peter

> Doing the same with buttons has been supported, but
> wheels and strips were out of luck because they would require too
> few arguments to 'set'.
> 
> Signed-off-by: Jason Gerecke <kil...@gm...>
> ---
>  tools/xsetwacom.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
> index d99a671..59b0cb1 100644
> --- a/tools/xsetwacom.c
> +++ b/tools/xsetwacom.c
> @@ -1554,7 +1554,7 @@ static void set(Display *dpy, int argc, char **argv)
>  	char **values;
>  	int nvals;
>  
> -	if (argc < 3)
> +	if (argc < 2)
>  	{
>  		usage();
>  		return;
> -- 
> 1.7.4.1