#208 0.12.0 & 0.12.1 broken for kernel 2.6.37

closed-fixed
nobody
5
2012-07-23
2011-12-22
munix9
No

the build for kernel 2.6.37 is broken (x32 + x64).

following an extract from the build log of obs (openSUSE build service):

+ make clean
Making clean in .
make[1]: Entering directory `/usr/src/packages/BUILD/input-wacom-0.12.1'
make[1]: Nothing to be done for `clean-am'.
make[1]: Leaving directory `/usr/src/packages/BUILD/input-wacom-0.12.1'
+ mkdir -p obj
+ for flavor in default desktop xen
+ rm -rf obj/default
+ cp -r 2.6.36 obj/default
+ make -C /usr/src/linux-obj/x86_64/default modules M=/usr/src/packages/BUILD/input-wacom-0.12.1/obj/default
make: Entering directory `/usr/src/linux-2.6.37.6-0.9-obj/x86_64/default'
make -C ../../../linux-2.6.37.6-0.9 O=/usr/src/linux-2.6.37.6-0.9-obj/x86_64/default/. modules
CC [M] /usr/src/packages/BUILD/input-wacom-0.12.1/obj/default/wacom_wac.o
/usr/src/packages/BUILD/input-wacom-0.12.1/obj/default/wacom_wac.c: In function 'wacom_mt_touch':
/usr/src/packages/BUILD/input-wacom-0.12.1/obj/default/wacom_wac.c:703:4: error: implicit declaration of function 'input_mt_get_value'
make[3]: *** [/usr/src/packages/BUILD/input-wacom-0.12.1/obj/default/wacom_wac.o] Error 1
make[2]: *** [_module_/usr/src/packages/BUILD/input-wacom-0.12.1/obj/default] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
make: Leaving directory `/usr/src/linux-2.6.37.6-0.9-obj/x86_64/default'
error: Bad exit status from /var/tmp/rpm-tmp.wfUiFF (%build)

'input_mt_get_value' (and others) should be present in linux/input/mt.h, but mt.h isn't available in kernel 2.6.37
this is correct excluded with
#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,37)
#include <linux/input/mt.h>
#endif
in 2.6.36/wacom.h and 2.6.36/wacom_w8001.c

Discussion

  • Chris Bagwell
    Chris Bagwell
    2012-01-05

    • status: open --> pending
     
  • Chris Bagwell
    Chris Bagwell
    2012-01-05

    This has been fixed in the git version of software and should be in next release.

     
  • munix9
    munix9
    2012-01-05

    jepp, it compiles fine now. I've added a patch with the new code between version 0.12.1 and current git:
    https://build.opensuse.org/package/show?package=wacom&project=home%3Amunix9

    I've not yet tested the compiled modules on openSUSE 11.4 (kernel 2.6.37) cause my system is already running a 3.x kernel (openSUSE_11.4_Extended on obs).
    I'll try this out in a vm later.

    thanks!

    ciao
    paolo

     
  • Ping Cheng
    Ping Cheng
    2012-07-23

    • status: pending --> closed-fixed