From: Antonino D. <ad...@po...> - 2003-01-21 00:18:06
|
On Tue, 2003-01-21 at 03:09, Jak wrote: > > > int __init rivafb_init(void) > > { > > - int err; > > - err = pci_module_init(&rivafb_driver); > > - if (err) > > - return err; > > - pci_register_driver(&rivafb_driver); > > - return 0; > > + return pci_module_init(&rivafb_driver); > > } > > Hmm, come to think of it, pci_module_init() is old-style. Using return (pci_register_driver(&rivafb_driver) > 0) ? 0 : -ENODEV; instead is better and will allow the rivafb driver to appear in sysfs. Anyway, pci_module_init() should not be called since pci_register_driver() already does that for you. That's what causing the "Badness" in kobject. Tony |