From: Geert U. <ge...@li...> - 2001-11-29 07:53:21
|
On Wed, 28 Nov 2001, James Simmons wrote: > +struct fb_copyarea { > + __u32 sx; /* screen-relative */ > + __u32 sy; > + __u32 width; > + __u32 height; > + __u32 dx; > + __u32 dy; > +}; > + > +struct fb_fillrect { > + __u32 x1; /* screen-relative */ > + __u32 y1; Why call them x1 and y1 here? > + __u32 width; > + __u32 height; > + __u32 color; > + __u32 rop; > +}; > + > +struct fb_image { > + __u32 width; /* Size of image */ > + __u32 height; > + __u16 x; /* Where to place image */ > + __u16 y; And x and y here? I'd vote for either x/y or dx/dy (destinatation x/y). > + __u32 fg_color; /* Only used when a mono bitmap */ > + __u32 bg_color; > + __u8 depth; /* Dpeth of the image */ Depth > + char *data; /* Pointer to image data */ > +}; > + Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li... In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds |