Re: [Linux-fbdev-devel] [RFC 2.6.26-rc3 0/5] am200epd, pxafb, metronomefb changes v2

[Krzysztof H. <krz...@po...>]

On Sat, 31 May 2008 00:41:50 -0400
Jaya Kumar <jay...@gm...> wrote:

> 
> Hi Eric, arm and fbdev friends,
> 
> This is version 2 of this RFC and contains the following updates:
> - skip setting g_options to __initdata since it is used both by init and
>   probe functions 
> - fix ordering of iounmap/release_mem_region
> - fix setting of smem_len (thanks to Krzysztof for above feedback)
> - make user_wfm_size static as caught by sparse 
> 

Hey, slow down. I have intended to review all your patches, but I have not had
enough time yet. Please wait till Monday.

Also, if the am200epd changes are less then say 40% of the original
driver I would prefer to see an incremental patch, not replacement of
the driver as it is not clear what was changed.

Kind regards,
Krzysztof


----------------------------------------------------------------------
Mucha powraca!
Sprawdz >>> http://link.interia.pl/f1e0d