From: Geert U. <Gee...@so...> - 2007-08-08 12:12:28
|
>From looking at the code flow, `int first' in fb_create_modedb() should be static. Signed-off-by: Geert Uytterhoeven <Gee...@so...> --- Or should it be initialized to 1 outside the loop? drivers/video/fbmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/video/fbmon.c +++ b/drivers/video/fbmon.c @@ -606,7 +606,7 @@ static struct fb_videomode *fb_create_mo pr_debug(" Detailed Timings\n"); block = edid + DETAILED_TIMING_DESCRIPTIONS_START; for (i = 0; i < 4; i++, block += DETAILED_TIMING_DESCRIPTION_SIZE) { - int first = 1; + static int first = 1; if (!(block[0] == 0x00 && block[1] == 0x00)) { get_detailed_timing(block, &mode[num]); With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Gee...@so... Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619 |