From: Jon S. <jon...@gm...> - 2005-08-22 15:57:25
|
On 8/22/05, Geert Uytterhoeven <ge...@li...> wrote: > On Fri, 19 Aug 2005, Jon Smirl wrote: > > The patch is just for testing, don't send it on. The radeonfb portion > > is definitely not finished. > > > > This adds an optional function to each driver that advertises what > > configs it offers. > > > > +char *radeonfb_getconfigs(struct fb_info *info) > > +{ > > + return "I4\nI8\nA1R5G5B5\nR5G6B5\nR8G8B8\nA8R8G8B8\nA4R4G4B4\nA8I= 8\nA2R10G10B10\n"; > > +} > > > > static struct fb_ops radeonfb_ops =3D { > > .owner =3D THIS_MODULE, > > @@ -1873,6 +1909,7 @@ static struct fb_ops radeonfb_ops =3D { > > .fb_fillrect =3D radeonfb_fillrect, > > .fb_copyarea =3D radeonfb_copyarea, > > .fb_imageblit =3D radeonfb_imageblit, > > + .fb_get_configs =3D radeonfb_getconfigs, > > }; >=20 > Do we really need this? It is optional. It's used in sysfs, where you cat the config variable to get a list of valid configs. Once in sysfs a program could then use it to generate a list to pick from, etc... It seems hard to use the search method if you are looking for a config that is in the middle of the list. --=20 Jon Smirl jon...@gm... |