#1 Nicstar patch

closed
nobody
None
5
2008-01-10
2002-11-27
Anonymous
No

Kĺre Särs discovered the bug described below in the
nicstar driver and sent me a patch. I added yet another
fix (the driver wasn't rejecting unsupported traffic
classes), and this is the result.
This is meant for the 2.4.19 kernel.

Original bug:
If you open a CBR TX only connection on a specific
vpi/vci and later open a RX only connection on the same
vpi/vci, the RX connection ill overwrite the pointer to
the SCQ of the TX connection. This changes the cell
rate of the TX channel and what is worse is that when
the TX connection is closed we get a segmentationfault
and the TX part of the vpi/vci remains reserved.

The bug in the driver is that if the opened channel is
not TX CBR, the driver assumes it is TX UBR. I have
attached a patch that adds a check for TX UBR.

Discussion

  • chas williams
    chas williams
    2008-01-10

    Logged In: YES
    user_id=410152
    Originator: NO

    this was fixed some time ago.

    http://lkml.org/lkml/2002/11/27/77

     
  • chas williams
    chas williams
    2008-01-10

    • status: open --> closed