Thread: [limesurvey-developers] Just for some user patch
The leading Open Source survey tool
Brought to you by:
c_schmitz
From: Denis C. <cou...@sh...> - 2011-01-31 13:58:50
Attachments:
signature.asc
|
Hello, I just ask for 2 user patch submited in bug report. 1: Fix table row heights for the display responses table ( http://bugs.limesurvey.org/view.php?id=4897 ). I think it's a good idea to put it in 1.91, if OK, i take it. 2: Allow multi Quota for List (radio) question type and other single select ( http://bugs.limesurvey.org/view.php?id=4895) Just to know if it's OK for 1.91RC4 ? http://bugs.limesurvey.org/view.php?id=4911 aren't a bug for me. And if you use display:none , then you can modify input content (you have to use position:absolute) Thanks all. |
From: Thibault Le M. <Thi...@su...> - 2011-01-31 14:09:33
|
Hi Denis, Le 31/01/2011 14:57, Denis Chenu a écrit : > Hello, > > I just ask for 2 user patch submited in bug report. > > 1: Fix table row heights for the display responses table ( > http://bugs.limesurvey.org/view.php?id=4897 ). > I think it's a good idea to put it in 1.91, if OK, i take it. I would say it's ok to commit this in the limesurvey/ branch as long as you do this the correct CSS-way ;-) > 2: Allow multi Quota for List (radio) question type and other single > select ( http://bugs.limesurvey.org/view.php?id=4895) > Just to know if it's OK for 1.91RC4 ? Hum, I'm not so sure about this one. As far as I am concerned, I think that the quota-conditions are very limited: I'm not even sure all question types are supported yet. If we begin to add smal workarounds like this, we may have difficulty in the future if we want to do it the right way. I would vote to postpone such tricks and try to see if we could work or refactoring the quota-conditions.... and maybe at the same time refactoring the show/hide conditions as well. > http://bugs.limesurvey.org/view.php?id=4911 aren't a bug for me. And if > you use display:none , then you can modify input content (you have to > use position:absolute) the pb is that in group by group mode there is no "display: none" cause the question is simply not added (no HTML at all). > Thanks all. > > > > > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > > > _______________________________________________ > limesurvey-developers mailing list > lim...@li... > https://lists.sourceforge.net/lists/listinfo/limesurvey-developers |
From: Denis C. <cou...@sh...> - 2011-01-31 14:38:27
Attachments:
signature.asc
|
Le 31/01/2011 15:09, Thibault Le Meur a écrit : > Hi Denis, > > Le 31/01/2011 14:57, Denis Chenu a écrit : >> Hello, >> >> I just ask for 2 user patch submited in bug report. >> >> 1: Fix table row heights for the display responses table ( >> http://bugs.limesurvey.org/view.php?id=4897 ). >> I think it's a good idea to put it in 1.91, if OK, i take it. > > I would say it's ok to commit this in the limesurvey/ branch as long > as you do this the correct CSS-way ;-) OK :) > >> 2: Allow multi Quota for List (radio) question type and other single >> select ( http://bugs.limesurvey.org/view.php?id=4895) >> Just to know if it's OK for 1.91RC4 ? > > Hum, I'm not so sure about this one. > As far as I am concerned, I think that the quota-conditions are very > limited: I'm not even sure all question types are supported yet. > If we begin to add smal workarounds like this, we may have difficulty > in the future if we want to do it the right way. > > I would vote to postpone such tricks and try to see if we could work > or refactoring the quota-conditions.... and maybe at the same time > refactoring the show/hide conditions as well. Yes , quota is very complicated actually, and not optimized like condition. But this may appear like a bug for some user. > >> http://bugs.limesurvey.org/view.php?id=4911 aren't a bug for me. And if >> you use display:none , then you can modify input content (you have to >> use position:absolute) > > the pb is that in group by group mode there is no "display: none" > cause the question is simply not added (no HTML at all). It work like a charm in group by group mode, see the link example at bugs report :) I only have to add a Text only question in first group (if none, Undefined offset: -1 in /home/sondages.pro/htdocs/limesurvey-svn/group.php on line 359 , cause group aren't display at all) |