Tutoring is a survey just like generic data collection is a survey, right Juhan.

P.S. I do not agree with the above statement.

M


On 6/5/08 9:48 AM, "Brian Staats" <bstaats@mitre.org> wrote:

I didnt know you were developing Limesurvey 2 into not a language tutor as well.

When will the tutoring feature be done by?  :p

On 5, 2008, at 9:45 AM, Macasek, Michael A. wrote:

They are learning a new language.... :)
 
 M
 
 
 On 6/5/08 9:39 AM, "Brian Staats" <bstaats@mitre.org> wrote:
Jun

 
Amit, Anyone,
 
 Can you give a use case where a user would want to change the language between sessions?
 
 
 On Jun 5, 2008, at 9:28 AM, Macasek, Michael A. wrote:
 
 
Well it should be available to change from the UI just for the current session too and I think that is Amits argument.
  
  M
  
  
  On 6/5/08 9:22 AM, "Brian Staats" <bstaats@mitre.org> wrote:
  
  
 
Thanks for the contribution Amit!
  
  >From the UI standpoint, I would agree with the language selection being a user preference (set upon signup/settings/configuration) and not every time a user logs in.
  
  Thanks again Amit, Its exciting to see more developers jumping on LS2
  
  
  On Jun 5, 2008, at 7:50 AM, Macasek, Michael A. wrote:
  
  
 
Amit,
   
   I saw you checked in a language selector for the login page, way to go!!!
   
   I do have a few comments/suggestions on your implementation.
   
   First, this functionality should probably not be in the beforeFilter. The idea of the before filter is that it is executed before EVERY action in that method. That means it happens for the welcome, create, logout, and retrieve when it only needs to happen for welcome page login POST. As such it should be moved to the welcome action, but not as it is, it should be wrapped up in a helper method most likely in the controllers/components/utils.php UtilsComponent (maybe we want to start a LanguagesComponent here or add it to the LocalizationComponent?).  In the welcome action you should probably do this first thing.
   
   Also why are you doing
$_SESSION['Config']['language'] = $thislanguage;, we should never be writing to the session global object. Does something expect this to be set?  The only refernce I can find to it in the code is cake/lib/i18n.php getInstance method but if you notice it checks:
   
   Configure::read('Config.language');
   
   Too so if we need this we should set it in the config object like:
   
   Configure::write('Config.language', $thislanguage);
   
   The line:
   
   
$this->L10n = new L10n();
   
  
Should probably not be in the new method as it is needed by the action so it should be created there.
   
   Also in the welcome method your additions:
   
   
$this->set('languagelist',$this->Localization->getLanguageListData());
   $this->set('languagelistdefault',$this->L10n->lang);
   
  
Should not be done at the top of the method, they need to be done only if the user is actually getting to the welcome page. These lines should be moved down where the other $this->set is happening in the welcome method.
   
   On another note, do we really want to be handling languages this way? Shouldn’t we be reading this from the users preferences? Yes they will not have the setting before their first login, but generally speaking we should let the users profile/survey language setting dictate the UI language configuration.
   
   Please do not take these comments in a negative way that is not my intention. Let me know if you have any questions on my comments.
   
   Again thanks for contributing!!!!
   
   Michael
    -------------------------------------------------------------------------
  Check out the new SourceForge.net Marketplace.
  It's the best place to buy or sell services for
  just about anything Open Source.
  http://sourceforge.net/services/buy/index.php_______________________________________________
  limesurvey-developers mailing list
  limesurvey-developers@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
  
 

  
  
 

-------------------------------------------------------------------------
  Check out the new SourceForge.net Marketplace.
  It's the best place to buy or sell services for
  just about anything Open Source.
  http://sourceforge.net/services/buy/index.php
  
 

_______________________________________________
  limesurvey-developers mailing list
  limesurvey-developers@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
  
 

   -------------------------------------------------------------------------
 Check out the new SourceForge.net Marketplace.
 It's the best place to buy or sell services for
 just about anything Open Source.
 http://sourceforge.net/services/buy/index.php_______________________________________________
 limesurvey-developers mailing list
 limesurvey-developers@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
 

 
 

-------------------------------------------------------------------------
 Check out the new SourceForge.net Marketplace.
 It's the best place to buy or sell services for
 just about anything Open Source.
 http://sourceforge.net/services/buy/index.php
 

_______________________________________________
 limesurvey-developers mailing list
 limesurvey-developers@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
 

  -------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php_______________________________________________
limesurvey-developers mailing list
limesurvey-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

_______________________________________________
limesurvey-developers mailing list
limesurvey-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers