Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#214 fix crash for empty links in feeds

closed-accepted
Lars Windolf
GUI (1)
5
2012-09-01
2012-08-14
msquared
No

in case of empty links in feeds liferea crashed with the
following backtrace:
#0 in __strstr_sse42 () from /lib/libc.so.6
#1 in liferea_webkit_launch_url (scrollpane=<>, url=0x0) at webkit.c:515
#2 in itemlist_selection_changed (item=item@entry=<>) at itemlist.c:599

this patch fixes the crash with showing the default itemview content
instead of trying to launch the browser with the non-existing URL

Discussion

  • msquared
    msquared
    2012-08-14

    forgot to mention: this fix is based on current liferea-1_8 (21d125) but should also fit on current master (not tested though)

     
  • Lars Windolf
    Lars Windolf
    2012-08-16

    Thanks for the patch! I've merged a slightly modified solution with the git branch for 1.8 and git master.

    To be released with 1.8.8 and 1.9.4

     
  • Lars Windolf
    Lars Windolf
    2012-08-16

    • assigned_to: nobody --> llando
    • status: open --> open-accepted
     
  • Lars Windolf
    Lars Windolf
    2012-09-01

    • status: open-accepted --> closed-accepted
     
  • Lars Windolf
    Lars Windolf
    2012-09-01

    Patch was released with 1.9.4