#201 Open social bookmarking in tab

closed-accepted
Lars Windolf
None
5
2011-06-21
2011-04-04
No

This patch changes it so that social bookmarking is handled in a new tab within liferea instead of in the browser.

Discussion

  • Lars Windolf
    Lars Windolf
    2011-04-15

    • assigned_to: nobody --> llando
    • status: open --> pending
     
  • Lars Windolf
    Lars Windolf
    2011-04-15

    With the current behaviour (opening social links) in your configured webbrowser we ensure that the login credentials do persist (if the user has chosen so in the browser). By moving the social login into Liferea we ensure that the end user has to login each time anew.

    I think this would not be a good idea. Nonetheless I do understand why it would be better to have the dialog open up in a tab.

    What do you think?

     
  • Strange.. With the few websites I tested it with on my machine I didn't need to log in each time.

    I personally think that work should be done so that handling link bookmarking can be handled in a tab (or even a popup window) then leave the current behavior of handling it in the browser as an option. But I know one of the goals of the project is simplicity and I don't know if that is adding too much complexity.

     
  • This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
    • status: pending --> closed
     
  • Lars Windolf
    Lars Windolf
    2011-04-30

    • status: closed --> open
     
  • Lars Windolf
    Lars Windolf
    2011-04-30

    Reopening...

     
  • Lars Windolf
    Lars Windolf
    2011-06-07

    • status: open --> open-accepted
     
  • Lars Windolf
    Lars Windolf
    2011-06-07

    After retesting I think you are right: Webkit somehow keeps the cookie during the session. Therefore I think your patch makes sense.

    Merged with git master. To be released with 1.7.6

    Thanks for the work!

     
  • Lars Windolf
    Lars Windolf
    2011-06-21

    Released with 1.7.6.

     
  • Lars Windolf
    Lars Windolf
    2011-06-21

    • status: open-accepted --> closed-accepted