#1100 liferea --debug-gui crashes with segmentation fault (nullpointer access)

git_master
closed-fixed
Lars Windolf
None
5
2013-07-28
2013-07-26
genodeftest
No

When running liferea with --debug-gui parameter it always crashes for me with a segmentation fault. full backtrace attached.

It seems like the debug1() call from itemlist.c:568 should be moved below if(item) in line 573 so it will only be executed when item != NULL.

1 Attachments

Discussion

  • genodeftest
    genodeftest
    2013-07-26

    diff --git a/src/itemlist.c b/src/itemlist.c
    index 342e637..aa18259 100644
    --- a/src/itemlist.c
    +++ b/src/itemlist.c
    @@ -565,12 +565,12 @@ itemlist_selection_changed (itemPtr item)
                       more matching the display rules because they have changed state */
                    itemlist_check_for_deferred_action ();
    
    -               debug1 (DEBUG_GUI, "item list selection changed to \"%s\"", item_get_title (item));
    -               
                    itemlist_set_selected (item);
    
                    /* set read and unset update status when selecting */
                    if (item) {
    +                       debug1 (DEBUG_GUI, "item list selection changed to \"%s\"", item_get_title (item));
    +                       
                            gchar   *link = NULL;
                            nodePtr node = node_from_id (item->nodeId);
    
     
  • Lars Windolf
    Lars Windolf
    2013-07-28

    • status: open --> open-fixed
    • assigned_to: Lars Windolf
     
  • Lars Windolf
    Lars Windolf
    2013-07-28

    I made the title output conditional because it is important to know when item list selection is set to NULL. Should solve the issue.

    To be released with 1.10.1

     
  • Lars Windolf
    Lars Windolf
    2013-07-28

    • status: open-fixed --> closed-fixed
     
  • Lars Windolf
    Lars Windolf
    2013-07-28

    Fix released with 1.10.1