#1094 1.10.0 aol_source.c should be in potfiles.skip?

v1.10
closed-fixed
Lars Windolf
None
3
2013-07-28
2013-07-16
David Smith
No

Hello.

Working on packaging of Liferea for Debian. I was starting from packaging for 1.10~rc4 and pulled in the new source code for 1.10.0. The build is now failing with the following error:

The following files contain translations and are currently not in use. Please
consider adding these to the POTFILES.in file, located in the po/ directory.

src/fl_sources/aol_source.c

If some of these files are left out on purpose then please add them to
POTFILES.skip instead of POTFILES.in. A file 'missing' containing this list
of left out files has been written in the current directory.
Please report to liferea-devel@lists.sourceforge.net
if [ -r missing -o -r notexist ]; then \ exit 1; \ fi
make[2]: [check] Error 1
make[2]: Leaving directory /tmp/buildd/liferea-1.10.0/po' make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory/tmp/buildd/liferea-1.10.0'
dh_auto_test: make -j8 check returned exit code 2
make:
[build] Error 29
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package

I've created a patch that adds src/fl_sources/aol_source.c to the potfiles.
add-aol-source-to-potfiles.patch

--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -154,6 +154,7 @@
src/parsers/rss_channel.h
src/parsers/rss_item.c
src/parsers/rss_item.h
+src/fl_sources/aol_source.c
src/fl_sources/default_source.c
src/fl_sources/default_source.h
src/fl_sources/dummy_source.c

Discussion

  • Lars Windolf
    Lars Windolf
    2013-07-22

    • status: open --> open-fixed
    • assigned_to: Lars Windolf
    • Priority: 5 --> 3
     
  • Lars Windolf
    Lars Windolf
    2013-07-22

    Fixed in git master. Not really criticial though as AOL code is unused for now.

     
  • Lars Windolf
    Lars Windolf
    2013-07-28

    • status: open-fixed --> closed-fixed
     
  • Lars Windolf
    Lars Windolf
    2013-07-28

    Fix released with 1.10.1