#1037 pops update notifications for Google Reader feeds that have

v1.8
closed-fixed
Lars Windolf
Misc (88)
5
2012-12-25
2012-11-01
Anonymous
No

Using liferea 1.8.6-1 in Debian Wheezy.
Using KDE Plasma Desktop version 4.8.4 in Debian Wheezy.

libnotify4 0.7.5
libknotifyconfig4 4.8.4

Liferea pops feed update notifications for Google Reader feeds that have already been read.

With reader notifications enabled in liferea's settings.
Right click on a google reader feed and click "update".

When the update is complete, liferea sends an incorrect desktop notification that all the articles in the feed are new articles, but they've all been read before.

Discussion

  • David Smith
    David Smith
    2012-12-13

    Patch attached. Makes sure Liferea does not overwrite the local "read" status with "unread" status from Google Reader.

     
  • David Smith
    David Smith
    2012-12-15

    This is what it's doing during sync without the patch:
    1. Liferea downloads a feed
    2. Liferea pops a notification of a new feed
    3. User reads the feed
    4. Liferea downloads the same feed again to check for any updates (automatically scheduled)
    5. Liferea changes the feed the user just read back from "read" status to "unread" status
    6. Liferea pops a notification of a new feed item (same news item)
    7. Liferea sets the feed back to "read" status, I think when it refreshes the GUI.

    ...And this pretty much loops every few minutes or so.

    All I did was add an IF that says only update the readStatus if the local copy (oldItem) has not been read and the remote copy it's synchronizing with (newItem) has been read.

    The flag status doesn't impact the desktop notifications so I don't change it.

     
    Last edit: David Smith 2012-12-15
  • Lars Windolf
    Lars Windolf
    2012-12-24

    Hi David,

    thanks for the patch. I applied it to both 1.8 branch and git master.

    To be released soon!

     
  • Lars Windolf
    Lars Windolf
    2012-12-25

    Fix released with 1.8.11. Please retest!

     
  • Lars Windolf
    Lars Windolf
    2012-12-25

    • status: open --> closed-fixed
    • assigned_to: Lars Windolf