#16 x11vnc warnings (xorg7)

closed-fixed
None
5
2006-03-29
2006-02-27
Damir Perisa
No

i'm package maintainer of x11vnc in archlinux.
http://www.archlinux.org/packages.php?id=3945
using xorg 7.0.0, i tried to compile 0.8.1 and it
seems to be successfull. however, there were a lot of
warnings during compile you may be interested in. an
excerpt is posted at bottom here. if you need more
info or some testing of a fix/patch, feel free to
contact me.

In file included from ../rfb/rfbproto.h:62,
from ../rfb/rfb.h:40,
from x11vnc.h:35,
from xwrappers.c:3:
../rfb/keysym.h:1531:1: warning:
"XK_Hangul_SsangKiyeog" redefined
In file included from /usr/include/X11/keysym.h:74,
from x11vnc.h:28,
from xwrappers.c:3:
/usr/include/X11/keysymdef.h:1649:1: warning: this is
the location of the previous definition
In file included from ../rfb/rfbproto.h:62,
from ../rfb/rfb.h:40,
from x11vnc.h:35,
from xwrappers.c:3:
../rfb/keysym.h:1532:1: warning:
"XK_Hangul_KiyeogSios" redefined
In file included from /usr/include/X11/keysym.h:74,
from x11vnc.h:28,
from xwrappers.c:3:
/usr/include/X11/keysymdef.h:1650:1: warning: this is
the location of the previous definition
In file included from ../rfb/rfbproto.h:62,
from ../rfb/rfb.h:40,
from x11vnc.h:35,
from xwrappers.c:3:
../rfb/keysym.h:1533:1: warning: "XK_Hangul_Nieun"
redefined
In file included from /usr/include/X11/keysym.h:74,
from x11vnc.h:28,
from xwrappers.c:3:
/usr/include/X11/keysymdef.h:1651:1: warning: this is
the location of the previous definition
In file included from ../rfb/rfbproto.h:62,
from ../rfb/rfb.h:40,
from x11vnc.h:35,
from xwrappers.c:3:
../rfb/keysym.h:1534:1: warning:
"XK_Hangul_NieunJieuj" redefined
In file included from /usr/include/X11/keysym.h:74,
from x11vnc.h:28,
from xwrappers.c:3:
/usr/include/X11/keysymdef.h:1652:1: warning: this is
the location of the previous definition
In file included from ../rfb/rfbproto.h:62,
from ../rfb/rfb.h:40,
from x11vnc.h:35,
from xwrappers.c:3:
../rfb/keysym.h:1535:1: warning:
"XK_Hangul_NieunHieuh" redefined
In file included from /usr/include/X11/keysym.h:74,
from x11vnc.h:28,
from xwrappers.c:3:
/usr/include/X11/keysymdef.h:1653:1: warning: this is
the location of the previous definition
In file included from ../rfb/rfbproto.h:62,
from ../rfb/rfb.h:40,
from x11vnc.h:35,
from xwrappers.c:3:
../rfb/keysym.h:1536:1: warning: "XK_Hangul_Dikeud"
redefined
In file included from /usr/include/X11/keysym.h:74,
from x11vnc.h:28,
from xwrappers.c:3:
/usr/include/X11/keysymdef.h:1654:1: warning: this is
the location of the previous definition
In file included from ../rfb/rfbproto.h:62,
from ../rfb/rfb.h:40,
from x11vnc.h:35,
from xwrappers.c:3:

Discussion

  • Logged In: YES
    user_id=27066

    Well, this is not strictly a bug.

    Anyhow, could you please look into X.org's keysym.h and tell
    me which guard it #define's?

    We have this in rfb/keysym.h:

    #ifndef KEYSYM_H
    #define KEYSYM_H

    which works well enough with XFree86...

     
    • assigned_to: nobody --> dscho
     
  • Damir Perisa
    Damir Perisa
    2006-03-01

    /usr/include/X11/keysym.h

     
    Attachments
  • Damir Perisa
    Damir Perisa
    2006-03-01

    /usr/include/X11/keysymdef.h

     
    Attachments
  • Damir Perisa
    Damir Perisa
    2006-03-01

    Logged In: YES
    user_id=1144678

    i've attached the two files containing this related
    defines ... these are from xorg7.0.0

    sorry my english, but i don't understand the "tell me which
    guard it #define's?" ... what do you mean with "which
    guard"?

    the file specified at /usr/include/X11/keysym.h:74
    is /usr/include/X11/keysymdef.h ... inside x11vnc it seems
    to be everything in rfb/keysym.h as far i see.

     
  • Steven Carr
    Steven Carr
    2006-03-28

    Logged In: YES
    user_id=345307

    Xorg (6.9.0) does not have guarding #ifdef on keysym.h
    You *could* do something like this in libvncserver

    #ifndef XK_BackSpace
    #include <rfb/keysym.h>
    #endif

    It is not the right thing to do, but it eliminates the
    redefinition warnings on Xorg 6.9.0

     
    • status: open --> closed
     
    • status: closed --> closed-fixed
     
  • Logged In: YES
    user_id=27066

    I changed the guards of rfb/keysym.h instead. The whole file
    is only interpreted now, if XK_0 is not defined.

    I am quite certain (despite lack of confirmation by daperi)
    that this fixes the bug. Thereby I declare it resolved.

     
  • Damir Perisa
    Damir Perisa
    2006-03-29

    Logged In: YES
    user_id=1144678

    very sorry about the missing signal from my side... real
    life gets busy and i forget software related tasks...

    here for the documents my confirmation: the changed
    behaviour fixes this

    thank you for your work!