#8 Fix Bug Request ID: 1110812 - no progress error; large files

closed-accepted
7
2006-03-10
2006-02-27
Don Malcolm
No

Files over 4 Gig in size encountered an error
resulting in an unsuccessful copy as per Bug Request
ID: 1110812.

The assignment 'len = job->basis_len' sometimes
overflows. Made changes so that assignment is done
only when appropriate.

rs_mdfour variables B and C were observed to overflow
their 'int' definition. This has been changed to
'unsigned int', which is now consistent with like
coding in the openssl package.

Don Malcolm
sf [at] c [dot] donm [dot] net
Sydney, Australia

Discussion

  • Don Malcolm
    Don Malcolm
    2006-03-06

    Patch file

     
    Attachments
  • Don Malcolm
    Don Malcolm
    2006-03-06

    Logged In: YES
    user_id=1450893

    The patch file 4Gigbug.patch is essentially the same as
    4Gig.patch. It fixes a problem with white space, and some
    missing characters at the start of the first line.

     
  • Donovan Baarda
    Donovan Baarda
    2006-03-10

    Logged In: YES
    user_id=10273

    The md5sum overflow is not a problem... C will silently
    overflow and these are essentially just storage for 32bits.
    However, it is nicer to have them as unsigned...

    The other len overflowing bit is a good catch, though this
    is effectively a min() operation that can be done with a one
    line ? operator...

    I am applying a modified version of this patch to CVS right
    now..

     
  • Donovan Baarda
    Donovan Baarda
    2006-03-10

    • labels: --> Implementation
    • priority: 5 --> 7
    • assigned_to: nobody --> abo
     
  • Donovan Baarda
    Donovan Baarda
    2006-03-10

    Logged In: YES
    user_id=10273

    This patch has been applied in CVS. It will be included in the
    next release after the date of this comment (the date this patch
    was closed).

     
  • Donovan Baarda
    Donovan Baarda
    2006-03-10

    • status: open --> closed-accepted