#6 adds support for setting the time on the njb3

closed-fixed
Linus Walleij
None
5
2005-01-10
2003-01-02
Ben Levitt
No

- adds support for setting the time on the njb3
- also fixes a bug in the code to get the time from the
njb3. (needed to mask the bottom 4 bits, not the
bottom 3 (&15 instead of &7) )

with my current set up, my usb-uhci module freezes when
I try to use software to disconnect the njb3 after
performing some operations like setting the time. (On
NJB_Release, I segfault)

This still happens to me (before and after this patch),
but at least now the time gets successfully set before
I crash. And if I unplug the jukebox before the
NJB_Release command is sent, then I'm fine, and I can
keep using libnjb.

Any idea why the code crashes here?

Discussion

  • Ben Levitt
    Ben Levitt
    2003-01-02

     
    Attachments
  • Ben Levitt
    Ben Levitt
    2003-01-02

    Logged In: YES
    user_id=653427

    fixed a memory leak. :P

     
  • Ben Levitt
    Ben Levitt
    2003-01-02

    Logged In: YES
    user_id=653427

    I should maybe mention: I'm using

    Mandrake 9.0 - 2.4.19
    libusb-0.1.6-1
    current cvs libnjb
    (I removed libusb0.1_4-0.1.6a-2mdk, which I heard was buggy)

    firmware 1.30.08p (most recent as far as I know)

    I can send and receive mp3s, edit playlists, and change the
    owner name, (and set the time, now. :) ).

     
  • Linus Walleij
    Linus Walleij
    2004-12-10

    Logged In: YES
    user_id=473872

    Is this still pending or is it fixed in the current CVS/1.2?

     
  • Linus Walleij
    Linus Walleij
    2004-12-10

    • assigned_to: nobody --> snirkel
    • status: open --> closed-accepted
     
  • Linus Walleij
    Linus Walleij
    2004-12-10

    • status: closed-accepted --> open-accepted
     
  • Linus Walleij
    Linus Walleij
    2005-01-10

    • status: open-accepted --> closed-fixed