#1 Improve "const correctness"

open
Shaun Jackman
None
5
2006-08-20
2005-07-07
Markus Elfring
No

Would you like to apply the advices from the
article "http://en.wikipedia.org/wiki/Const_correctness"
to your sources?
I suggest to add the key word "const" to the type
specifiers of parameters like the following.
- data (function "playlist_unpack")

http://cvs.sourceforge.net/viewcvs.py/libnjb/libnjb/src/pla
ylist.h?rev=1.1&view=markup

- buf (function "usb_pipe_write")

http://cvs.sourceforge.net/viewcvs.py/libnjb/libnjb/src/usb
_io.h?rev=1.12&view=markup

Discussion

  • Linus Walleij
    Linus Walleij
    2006-08-20

    Logged In: YES
    user_id=473872

    Fixed some, won't fix more right now.

     
  • Linus Walleij
    Linus Walleij
    2006-08-20

    • status: open --> closed
     
  • Markus Elfring
    Markus Elfring
    2006-08-20

    • assigned_to: nobody --> tsirc
    • status: closed --> open
     
  • Markus Elfring
    Markus Elfring
    2006-08-20

    Logged In: YES
    user_id=572001

    I prefer to keep this issue open until the code will be
    completely cleaned up.

     
  • Linus Walleij
    Linus Walleij
    2006-08-20

    Logged In: YES
    user_id=473872

    OK then... :-)