[Libmesh-users] Some minor code corrections

[Michael S. <m-s...@us...>]

Hello,

after using and compiling Libmesh, I have a few suggestions for the
cvs branch of the Libmesh code:

1. mesh_modification should re-assign the element's id to the new one
   replacing the old (this is used in Mesh::all_second_order())
   Otherwise, all modificated elements will have the same (invalid) id.

2. the function MeshFunction::clear() is demanded as a virtual
   function by FunctionBase, but neither implemented nor declared
   anywhere.
   This leads to a compiler error when using a MeshFunction in a
   program (at least with gcc-2.95.4, but not with gcc-3.0)

3. In MeshFunction the PointLocator is first created, then
   initialized. But, in cvs (not in libmesh0.4.2) the PointLocator is
   already initialized after creation.

4. When constraining the DofMap with a new constraint-row, I always
   get the message, that it is already constrained. I think, the
   corresponding if-statement should not be negated.

I include some patches with suggestions for the above mentioned
problems. Maybe, you will find them useful.

Best greetings,
  Michael.

-- 
"A mathematician is a device for turning coffee into theorems"
  Paul Erdös.