Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#4 Windows libircclient including an old version of winsock

closed-rejected
George Yunaev
networking (2)
1
2006-08-29
2006-07-29
No

libircclient.h includes winsock.h, which contains
version 1.1 of the Windows sockets library. However, it
is common for applications to include winsock2.h, which
provides version 2.0 of the Windows sockets library. By
including winsock.h, you are preventing people from
including the newer version of winsock alongside
libircclient.

The best solution is probably to use winsock2.h in
libircclient. I don't think you'll need any other code
changes to do so.

Discussion

    • priority: 5 --> 4
     
    • summary: Windows library including an old version of winsock --> Windows libircclient including an old version of winsock
     
  • George Yunaev
    George Yunaev
    2006-08-29

    • status: open --> closed-rejected
     
  • George Yunaev
    George Yunaev
    2006-08-29

    Logged In: YES
    user_id=1115709

    And this will prevent people who use only winsock 1.1.

    I don't see how it prevents you to include winsock2 headers
    - include them BEFORE you include libircclient.h

     
  • George Yunaev
    George Yunaev
    2006-08-29

    • priority: 4 --> 1