Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#77 crash when rewriting Olympus MakerNote

closed-fixed
Jan Patera
libexif (61)
9
2007-08-17
2007-08-14
Raphaël Quinet
No

A critical bug has been reported against all GIMP versions that link with libexif. Loading a specific image containing Olympus MakerNotes causes libexif (and therefore GIMP) to consume huge amounts of memory and eventually crash the application if the machine does not have enough swap space.

Please have a look at this GIMP bug report that contains my preliminary analysis of the problem:
http://bugzilla.gnome.org/show_bug.cgi?id=466044

The problem occurs in exif_mnote_data_olympus_save(), when the size offset in the variable "s" suddenly gets the value 736481084. Please have a look at the GIMP bug report for details, since stack traces are usually easier to read in Bugzilla than in the Sourceforge bug tracker.

The test image is unfortunately too large to be attached here (3.8 MB > 256 KB). I have put a temporary copy on the web (see comment #11 in the GIMP bug report) but I will have to delete it in a few days so please grab your own copy as soon as possible.

Discussion

    • priority: 5 --> 9
     
  • Jan Patera
    Jan Patera
    2007-08-17

    • assigned_to: nobody --> patera
    • status: open --> closed-fixed
     
  • Jan Patera
    Jan Patera
    2007-08-17

    Logged In: YES
    user_id=943941
    Originator: NO

    This bug was introduced when fixing #1525770. In that bug, there was a file with big endian main Exif IFD but with little endian makernote. Now from 2 sources I see that there also exist images (taken by Canon E20) that have both main IFD and makernote IFD in big endian order. Majority of files is in little endian entirely. I added a really heuristical fix to detect that case. In CVS since yesterday.
    Same bug as #1774626.

     
  • Jan Patera
    Jan Patera
    2007-08-17

    Artifical small example - image & thumbnail don't match

     
  • Jan Patera
    Jan Patera
    2007-08-17

    Logged In: YES
    user_id=943941
    Originator: NO

    File Added: OlympusE20-ArtificalSample.jpg