Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#105 Build failed on tests

open
Dan Fandrich
exif (14)
5
2011-04-28
2011-04-28
NVieville
No

Hello,

A typo in the diff string in "Test tag of 0" test in test/check-show-description.sh file (line 34) exits compilation with error.
The patch provided in attachment corrects this typo.

Cordially,

--
NVieville

Discussion

  • NVieville
    NVieville
    2011-04-28

    Patch to fixes type in test/check-show-description.sh

     
  • Dan Fandrich
    Dan Fandrich
    2011-04-28

    • assigned_to: nobody --> dfandrich
     
  • Dan Fandrich
    Dan Fandrich
    2011-04-28

    The tests that come with exif 0.6.20 expect it to be linked to libexif 0.6.20. It appears that your exif has been linked to libexif 0.6.19, or another older version, which would cause this error.

     
  • NVieville
    NVieville
    2011-04-29

    Hello,

    Apologies, you are right!
    My Linux distribution (Fedora 14) provides libexif 0.6.19, but doesn't provide exif.
    So, I had to build exif rpm package myself and didn't notice in the build process any lack of dependencies unless the tests phase was reached. But nothing in the messages suggested that my libexif and libexif-devel version were not appropriate.
    If necessary and if I understand you correctly, do you think it would be appropriate to produce a new patch for the configure.ac file of the exif sources package, that checks actually for libexif >= 0.6.18 instead of >= 0.6.20 in this case?

    Thanks for your speedy response and apologies again for the noise.

    Cordially,

    --
    NVieville

     
  • Dan Fandrich
    Dan Fandrich
    2011-05-03

    Since exif actually works just fine with libexif 0.6.18, I'd rather not restrict users from using an older version if necessary. But since the test suite requires 0.6.20, it's probably a good idea to add a new test case that does nothing but checks for the latest version and fails with a mismatch. That will also catch cases where someone has accidentally compiled against an older version by mistake, but will still allow compiling against it if desired by skipping the tests. It would also be a good idea to display a warning at the end of configure if the libexif version doesn't match the exif version.