#29 cgconfigparser does not catch wrong control value

open
Balbir Singh
None
5
2008-10-07
2008-10-06
Sudhir Kumar
No

Hi,
The cgconfigparser was run with following config file [snipped]
cpuacct {
cpu.shares = 500;
}

memory {
memory.limit_in_bytes = 200M;
}
}

mount {
cpuacct = /container;
memory = /memory;
}

Looking at the config file, the control value to cpuacct { cpu.shares..... is wrong, which is never caught by the parser/library. seems the parser does not do anything with this value as I can put any junk value and there is no error at all.

Thanks
Sudhir

Discussion

  • Balbir Singh
    Balbir Singh
    2008-10-07

    Yes, it does indeed ignore values, some of that stems from us being agnostic about controller values. It definitely needs to be fixed. In the case that cpu, cpuacct are mounted together writing cpu.shares will not fail and thus we'll not be able to detect the error. Needs more investigation and discussion. With the plugin layer, most of these problems should go away.

     
  • Balbir Singh
    Balbir Singh
    2008-10-07

    • assigned_to: nobody --> balbir_singh