Hi!
While trying to write a toy for lib2geom, I came up with remarks about two points in the code.
Since I am not very confident in my C++, I prefer to post this here than comitting to svn...
"s-basis2d.h":
'us' and 'vs' properties were not initialised on creation. This caused me trouble when creating arrays of arrays of sbasis2d...
"s-basis.cpp":
the sqrt algorithm fails if the recieved sbasis has a lower degree than the degree up to which the sqrt is computed. I only have an ugly solution. Better ideas? (I think there should be no mathematical reason for producing an error when trying to read the coefficient of a polynomial of degree higher than the polynomial itself: it should simply be 0; but I don't know how to simulate this for sbasis)
I also join my "NormalBundle" toy...
A+, JF.
fanf
2006-12-05
fanf
2006-12-05
Deforms an sbasis along another one...
fanf
2006-12-06
Logged In: YES
user_id=1642629
Originator: YES
File Added: s-basis.cpp
fanf
2006-12-06
fanf
2006-12-06
Logged In: YES
user_id=1642629
Originator: YES
sbasis sqrt correction is a bit less stupid this way(!)...
File Added: s-basis.cpp
Nathan Hurst
2006-12-06
Logged In: YES
user_id=73796
Originator: NO
I've applied your patches, and added normal-bundle - thanks a bundle!
I've also given you write permission to svn.
Nathan Hurst
2006-12-06