#33 Ifdef for some files

closed
nobody
None
5
2012-02-11
2009-06-18
Dave Schuyler
No

Hi, please use ifdef around some whole files such as:
devpoll.c
kqueue.c
evthread_win32.c
and so on. Right now what you have works great with the Makefiles and such that you provide, but if someone uses an alternate make system, it's handy if these files do something like:
#include event-config.h
and right after that do

#ifdef HAVE_FOO_FEATURE

... rest of the file ...

#endif

Discussion

  • Nick Mathewson
    Nick Mathewson
    2009-09-11

    Seems like a decent idea to me, especially for people who use IDEs.

     
  • Nick Mathewson
    Nick Mathewson
    2012-02-11

    Merged a fix from Ross Lagerwall.

     
  • Nick Mathewson
    Nick Mathewson
    2012-02-11

    • status: open --> wont-fix
     
  • Nick Mathewson
    Nick Mathewson
    2012-02-11

    • status: wont-fix --> closed