#270 Crash when pressing ESC in an open menu

closed-fixed
nobody
None
5
2009-07-11
2006-10-16
Scott Tringali
No

1) Run lesstif-0.95.0/test/Xm/menushell/test4
2) Click "cascade2" (the bug does not manifest in "cascade1")
3) Press ESC

Result: crashes

Also in 0.94.4.

Discussion

<< < 1 2 (Page 2 of 2)
  • Thomas Orgis
    Thomas Orgis
    2009-03-25

    This seems to be the relevant change for the Ctrl+F reaction speed + keyboard focus.
    With the patch, lesstif-0.93.36 behaves like 0.93.18 ... applied to current cvs but not tested yet.

    diff -ruN lesstif-cvs-20090312/lib/Xm-2.1/Manager.c lesstif-cvs-20090312-shortcut-focus/lib/Xm-2.1/Manager.c
    --- lesstif-cvs-20090312/lib/Xm-2.1/Manager.c 2007-09-12 22:29:35.000000000 +0200
    +++ lesstif-cvs-20090312-shortcut-focus/lib/Xm-2.1/Manager.c 2009-03-25 01:24:19.000000000 +0100
    @@ -1930,7 +1930,7 @@
    item->key, item->keysym, item->modifiers,
    item->needGrab ? "Grabbing" : "Not Grabbing",
    item->isMnemonic ? "mnemonic" : "not mnemonic"));
    -#if 1
    +#if 0 /* effect of this block in nedit: fast shortcut reaction but unreliable keyboard input focus */
    switch (item->eventType) {
    case KeyPress:
    mask = KeyPressMask;
    @@ -1950,7 +1950,7 @@
    #endif
    mask = 0;
    }
    -#else
    +#else /* This code looks horribly wrong and makes slow shortcut reaction but at least is reliable (in nedit...). */
    mask = KeyPressMask;
    mask = item->eventType; /* This must be wrong but the alternatives crash nedit. FIX ME */
    #endif

     
  • @sobukus: yes, I intend to put some effort in getting things to work. But be prepared for a slow pace because I use it to learn some programming (finding bugs and regressions, no new features). And have other projects as well.

     
  • Danny Backx
    Danny Backx
    2009-03-25

    Those who want CVS update access to the LessTif sources should send me private E-mail.

    Danny

     
  • Thomas Orgis
    Thomas Orgis
    2009-03-29

    Hm, so we can expect some fixing in CVS (largely reverts of changes with side-effects)?
    Perhaps even a stabilizing release (even "just" for all the fixes accumulated in CVS anyway)?

     
  • Paul Gevers
    Paul Gevers
    2009-03-31

    @sobukus With respect to a stabilized release: I have asked for commit rights, I will see what I can do.

     
  • Paul Gevers
    Paul Gevers
    2009-04-29

    I committed the reversal of the changes in Traversal.c

    At least lesstif should not crash anymore on <ESC>. I will keep on working on lesstif, and hopefully I will be able to figure out what the intension of the original patch was.

     
  • Paul Gevers
    Paul Gevers
    2009-07-11

    The fix was included in the latest release (0.95.2).

     
  • Paul Gevers
    Paul Gevers
    2009-07-11

    • status: open --> closed-fixed
     
<< < 1 2 (Page 2 of 2)