#887 "Notes" field on invoices not propery escaped in PDFLaTeX

1.4
closed-fixed
Chris Travers
None
5
2014-01-17
2013-08-28
John Locke
No

When generating a PDF of an invoice, the "Notes" field does not properly escape all characters.

I have hit this with a variety of characters, and don't have a full list. The ones that seemed to trigger a problem today are "[" or "]".

Discussion

  • Chris Travers
    Chris Travers
    2013-09-15

    For 1.4, I think most of our problems would be solved by using Tex::Encode.

    We might want to consider this for 1.3 as well but should consider the issues regarding adding dependencies in a stable branch (given that this certainly affects all prior versions, I am thinking it should be fixed in 1.4 only)

     
  • Chris Travers
    Chris Travers
    2013-09-15

    Also note that Tex::Encode handles UTF-8 for Latin-like languages (meaning that XeTeX becomes necessary only for things with fundamentally different character sets which cannot be managed as LaTeX ligatures).

     
  • Chris Travers
    Chris Travers
    2013-09-15

    • Group: 1.3 --> 1.4
     
  • Chris Travers
    Chris Travers
    2013-09-15

    hmm thinking... Wondering if it would be worth auto-discovering Tex::Encode and using it if it exists for 1.3 If so, should certainly put that change in early in the release cycle.

     
  • Chris Travers
    Chris Travers
    2014-01-15

    • assigned_to: Chris Travers
     
  • Chris Travers
    Chris Travers
    2014-01-16

    LaTeX::Encode in its current version does not work. I have sent a patch to the author.

     
  • Chris Travers
    Chris Travers
    2014-01-17

    • status: open --> closed-fixed
     
  • Chris Travers
    Chris Travers
    2014-01-17

    svn 6489