Menu

#1204 Missing salutation and reserved values.

1.3
closed-fixed
None
9
2014-09-17
2014-09-08
rir
No

Still on 1.3.40.

My "pg_dump -a " does not include a line creating a blank salutation.

INSERT INTO salutation (id, salutation ) VALUES ('7', NULL); -- or ''

No salutation is better than the wrong one.

It would be good to bump entity_class_id_seq and salutation_id_seq up to a much higher value; reserving values allowing time and space for users/devs to coordinate use of the valuespaces.

Thanks,
rir

Discussion

  • Chris Travers

    Chris Travers - 2014-09-09

    I will take a look at this after 1.3.43 is released (probably this week).

     
  • Chris Travers

    Chris Travers - 2014-09-10

    I think my preferred solution here is just to drop the not null constraint on person.salutation_id and set up the drop down to include a blank line.

     
  • Chris Travers

    Chris Travers - 2014-09-12

    Interestingly salutation_id is nullable. So basically we just need to address the user interface side.

     
  • Chris Travers

    Chris Travers - 2014-09-17

    fix to be applied in 1.3.44. https://github.com/ledgersmb/LedgerSMB/pull/346

    If you need it in the mean time you can install from svn via Github.

     
  • Chris Travers

    Chris Travers - 2014-09-17
    • status: open --> closed-fixed
    • assigned_to: Chris Travers