[Lame-dev] [ lame-Bugs-1813496 ] AIFF parsing bug

[SourceForge.net <no...@so...>]

Bugs item #1813496, was opened at 2007-10-14 22:18
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100290&aid=1813496&group_id=290

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Frontends (lame/mp3x/...)
Group: Quality
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Rich Martin (datawrangler)
Assigned to: Nobody/Anonymous (nobody)
Summary: AIFF parsing bug

Initial Comment:
In frontend/get_audio.c, parse_aiff_header() has a couple of bugs which insert noisy artifacts into the audio data.

First, it fails to skip over any padding bytes which may occur between chunks. When parse_aiff_header() encounters padding bytes, parsing fails and OpenSndFile() erroneously assumes the AIFF file is Raw PCM. As a result, metadata is accepted as audio data and a "splat" of noise occurs at the beginning of the output MP3.

Second, the while() loop in parse_aiff_header() assumes the COMM chunk will be found before the SSND chunk. When reading files whose SSND chunk precedes the COMM chunk, aiff_check2() fails since no header data has been read. Again, this causes OpenSndFile() to erroneously assume Raw PCM, metadata leaks into the audio, and noise is introduced.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100290&aid=1813496&group_id=290