Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#413 --tg does not handle genre number when adding unicode tag

closed-fixed
5
2011-11-26
2011-11-23
tmkk
No

This is because id3tag_set_textinfo_utf16 is called directly when adding unicode tags.

Solution will be:
a) handle in frontend
b) handle (silently) in id3tag_set_textinfo_utf16 for TCON frame
c) add id3tag_set_genre equivalent for unicode

For solution c), the attached patch will do.

Discussion

  • tmkk
    tmkk
    2011-11-23

     
    Attachments
    • assigned_to: nobody --> robert
    • status: open --> pending-fixed
     
  • Thanks for reporting this issue, Talhei Monma!
    Actually, the auto correction feature was missing in the unicode case too.
    A fix will soon be available.

     
  • tmkk
    tmkk
    2011-11-26

    Now it works but v2.3 tag is not added when only --tg is specified.

    in id3tag_set_genre_utf16:

    gfc->tag_spec.flags |= CHANGED_FLAG;
    should be
    gfc->tag_spec.flags |= (CHANGED_FLAG | ADD_V2_FLAG);

    to fix this issue.

     
  • tmkk
    tmkk
    2011-11-26

    • status: pending-fixed --> open-fixed
     
  • That's not a bug, the --tg switch triggers an id3v2 tag only, if the user adds some genre, which isn't one of the common genres.

     
  • tmkk
    tmkk
    2011-11-26

    Hm, but --tg along with the --id3v2-latin1 switch (and lame prior to 3.99) always adds v2.3 tag.

     
  • tmkk
    tmkk
    2011-11-26

    • status: open-fixed --> closed-fixed
     
  • tmkk
    tmkk
    2011-11-26

    OK, sorry for my misunderstanding. --add-id3v2 or --id3v2-{latin1|utf16} is a trigger for v2.3 tag.

    Closing.