#125 Link to post not working on some blogs

v2.4
closed-fixed
6
2014-08-01
2012-10-17
Paul Ylioja
No

Link to post button is not working on some blogs. Mainly (only?) blogs that are not owned by the user but are submitting a post or comment to it.

Discussion

  • Colin Bird
    Colin Bird
    2012-10-21

    Just had this problem on blog@ChemTools, posting to DE ITaaU Network+, which I guess Jeremy owns. With three links in my post, it was a pain having to insert the markup by hand.

     
  • John Robinson
    John Robinson
    2013-01-22

    Can't reproduce this at the moment

     
  • Tim Parkinson
    Tim Parkinson
    2014-03-20

    I can partially reproduce this using Chrome on Aurora r754.
    Go to someone else's notebook that you can read.
    Type some text into the comment box and then click the Link to Post button.
    Nothing happens. There is no visible click action on the button and no
    Link to Post dialogue is launched.

    I cannot however edit a post and then not add a link.
    If the post is not writeable by me then I can't Edit it - get Forbidden as expected.
    But I may not have tried the right combination of ownership and permission settings.

     
  • Tim Parkinson
    Tim Parkinson
    2014-03-20

    • assigned_to: David R Newman
    • Group: --> v2.4
    • Priority: 5 --> 6
     
  • Tim Parkinson
    Tim Parkinson
    2014-03-20

    Dave, see if you can fathom it as a fresh pair of eyes.

     
  • David R Newman
    David R Newman
    2014-03-20

    When O try to click on this button in FireFox on Ubuntu 12.04, I get the following message in the error console.

    Error: ReferenceError: blog_id is not defined
    Source File: http://aurora.labtrove.org/inc/markitup/sets/bbcode/set.js
    Line: 51

    This looks like it should be a fairly trivial fix. Whether this will solve the problem I am unsure as of yet.

     
  • David R Newman
    David R Newman
    2014-03-20

    Comments and Posts use different editors. One loads linkblog in an iframe, the other as a separate window. The javascript in linkblog needs to be different depending on the use case. noiframe parameter in the GET header is used to differentiate. blog.fieldslection.js has been modified to update the textarea since it's name changed. blog_id is now set in the javascript in blog.php, so the markitup editor knows which blog is being commented on to load the appropriate blog in linkblog.

    Fixed in r757.

     
  • Tim Parkinson
    Tim Parkinson
    2014-06-02

    I think this has regressed. I remember a working version after you posted the last comment.
    But now I cannot put a link to another post into a comment at all.
    If you type a comment line then click on the Link to Post/Entry button, then the list of avaiable Entries launches in a separate window and the dropdown of notebooks works properly.
    However when you select an Entry to link to and click it then nothing happens.
    Regardless of privilege. I can't even add links to my own comments in my own notebook.

     
  • Tim Parkinson
    Tim Parkinson
    2014-06-02

    (Earliest broken version is r765 (RSC Chemtrove))
    I'm using IE 11, have not yet tried Chrome or Firefox.

     
  • David R Newman
    David R Newman
    2014-06-02

    This appears to be an IE specific bug. I have reproduced on IE11 (Windows7) when testing against aurora. Seems to work fine on FireFox (Windows 7 and Ubuntu) and Chrome (Ubuntu). Will need to investigate further into what the exact problem is.

     
  • David R Newman
    David R Newman
    2014-06-02

    So the problem I was having with IE11 was that I hadn't noticed the message that appeared at the bottom of my screen saying the popup had been blocked. Maybe this is the same for you Tim? Or maybe you have previously blocked popups by default for this page/site.

     
  • Tim Parkinson
    Tim Parkinson
    2014-06-03

    It works fine on Chrome for both entry body text and comment.

    There is one extra thing. If you edit an entry in IE11 and try to insert a link-to-entry in the body of the text then the link is prepended to the start of the text instead of where the cursor is. It works properly in Chrome.
    I just successfully linked to an entry in a comment using IE11. Did you change something overnight or is the problem more selective?

     
  • Tim Parkinson
    Tim Parkinson
    2014-06-03

    With regard to popups. No I don't think I have disabled them (although IE and Windows seem to take it upon themselves to change things without telling me).
    I do not see a popup blocked message.
    I do see the list of possible links and can select new note books from the dropdown.
    It's only when I click on a link to complete the insert that it fails (by dismissing the link dialogue without performing the insertion).

     
  • Tim Parkinson
    Tim Parkinson
    2014-08-01

    • status: open --> closed-fixed
     
  • Tim Parkinson
    Tim Parkinson
    2014-08-01

    Need to make a new bug ticket for the IE glitch that puts link to entry at the start of the text instead of where the cursor is.