#23 gcc 4.5 and small build system corrections for 0.3.7

open
nobody
5
2011-11-19
2011-11-19
Frank Schütte
No

Hallo, I tried to compile ktechlab 0.3.7 in openSUSE Build-System and found some minor problems.
My knowledge of C++ is limited, so hopefully I did not do something wrong.

gcc-4.5-patch: Changed som QPixmap::QPixmap() -> QPixmap()
doubled mentioning of files: for.png, while.png are mentioned 2 times in the Makefile, that gives on some distros install errors.
a missing dependency for logic.cpp makes build process fail sometimes on some distros.

I added a patch for this three issues.

Thank you for your good work on ktechlab. I do use it at school a lot.

Bye,
Frank

Discussion

  • Frank Schütte
    Frank Schütte
    2011-11-19

    zip file with patches

     
    Attachments
  • Zoltan P
    Zoltan P
    2011-12-08

    Thank you for your interest in KTechLab. I'm planning to merge it in January, into a maintenance-branch.

    Have a lot of fun,
    Zoltan

     
  • I found the same problem when compiling with SuSE 11.4 and using the gcc compiler:
    gcc version 4.5.1 20101208 [gcc-4_5-branch revision 167585] (SUSE Linux)
    The compiler told me what changes were needed - and the result compiled correctly.

    Anyway thanks for all your work - the program was just what I needed!!

    Regards,

    David Webb.

     
  • Zoltan P
    Zoltan P
    2012-09-30

    Hi,

    the sent patches have been applied to the Git repository here:

    https://github.com/ktechlab/ktechlab-0.3/tree/ktechlab-0.3.8

    I don't know when that branch will be released, but when it will be, the your fixes will be in it.

    Thank you for your contribution

    Zoltan