Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#3 run commands from command line in the Terminal Emulator

krusader_kde3-cvs
closed-accepted
Jonas Bähr
5
2007-03-18
2006-12-09
Vaclav Juza
No

I tried to add the possibility to run commands from command line in the
terminal emulator.
I integrated that with the patches of Jiří Paleček from 14.9. (if it doesn't
mind; I used his proposed changes) with some changes, so that in addition to methods normal, konsole and
collect output, there is run in TE.
In addition I added KRadioActions for switching command-line mode (used the
same principle as for setting compare-dir mode. And replaced on/off button
by button with a popup menu.

Since the changes are quite big, I splitted the patch into multiple stages,
where one does some particular thing, which I hope is better for review. If you want one file to apply, use

The patches are attached, here is the description:

kcmd_01createTE.diff:
moves creating the konsole part to separate method (used in 1* patches,
because it will be created even if not shown, when run in TE mode is chosen)

kcmd_02uabase.diff:
mostly from Jiří's patch - class KrActionBase, KrAction extends it.
a constant for the new mode added to enum execType.

kcmd_11kactions.diif:
adds actions, which change the mode. It sets private config value, which
will be used in the following patches

kcmd_12uactionTE.diff
adds the support of the new mode (run in terminal emulator) to the actions.

kcmd_21button.diff:
a new class for the button with popupmenu for selecting the mode (uses
actions from 11)

kcmd_31kcmd.diff:
the change of KCMDLine class. It extends KrActionBase and uses the new
button instead of toggle on/off

kcmd_32menu.diff:
adds the mode selection to the menu

kcmd_33CtrlO.diff:
Not necessary, adds an alternative shortcut Ctrl+O for show/hide terminal
emulator.

The numbering - patches with numbers in higher decade depend on patches in lower decades

Relationship with patches from Jiří Paleček:

Patch 02 is mostly taken from his patch, plus added one mode to the enum ExecType

Patch 31 modifies Kcmdline class. Some parts used from Jiří's patch (with small modifications), some (button in constructor) quite independent. Future Jiří's changes (completition) will affect this class as well, but will be probably easy to incorporate.

Discussion

1 2 3 > >> (Page 1 of 3)
  • Vaclav Juza
    Vaclav Juza
    2006-12-27

    Logged In: YES
    user_id=1317323
    Originator: YES

    The part kcmd_02uabase.diff is also contained (modified) in Jiri's expander patch (http://sourceforge.net/tracker/index.php?func=detail&aid=1622577&group_id=6488&atid=306488). If the expander.patch is applied, then only the other parts of this patch should be applied.

     
  • Vaclav Juza
    Vaclav Juza
    2006-12-28

    Logged In: YES
    user_id=1317323
    Originator: YES

    File Added: kcmd_31kcmd.diff

     
  • Vaclav Juza
    Vaclav Juza
    2007-02-09

    moves creating the konsole part to separate method (used in 1* patches, because it will be created even if not shown, when run in TE mode is chosen)

     
    Attachments
  • Vaclav Juza
    Vaclav Juza
    2007-02-09

    Logged In: YES
    user_id=1317323
    Originator: YES

    File Added: kcmd_01createTE.diff

     
  • Vaclav Juza
    Vaclav Juza
    2007-02-09

    Logged In: YES
    user_id=1317323
    Originator: YES

    File Added: kcmd_02uabase.diff

     
  • Vaclav Juza
    Vaclav Juza
    2007-02-09

    mostly from Jiří's patch - class KrActionBase, KrAction extends it. a constant for the new mode added to enum execType; do not use, if expander patch is applied (expander patch contain it)

     
    Attachments
  • Vaclav Juza
    Vaclav Juza
    2007-02-09

    Logged In: YES
    user_id=1317323
    Originator: YES

    File Added: kcmd_02uabase.diff

     
  • Vaclav Juza
    Vaclav Juza
    2007-02-09

    adds actions, which change the mode. It sets private config value, which will be used in the following patches

     
    Attachments
  • Vaclav Juza
    Vaclav Juza
    2007-02-09

    Logged In: YES
    user_id=1317323
    Originator: YES

    File Added: kcmd_11kactions.diff

     
  • Vaclav Juza
    Vaclav Juza
    2007-02-09

    adds the support of the new mode (run in terminal emulator) to the actions.

     
    Attachments
1 2 3 > >> (Page 1 of 3)