From: Jon D. <jd...@pm...> - 2007-11-28 19:43:19
|
> Maybe name this "Keyword" in the advanced screen? Bear in mind that we weren't searching for text in keywords (which is either a Krang field or it's a custom field in our implementation [??]) but any content--as in, keywords, metadata, paragraphs, .. anywhere. Jon -----Original Message----- From: Michael Peters [mailto:mp...@pl...]=20 Sent: Wednesday, November 28, 2007 12:39 PM To: Jon Davis Cc: kra...@li... Subject: Re: [Krang-devel] Feature request: add wildcard content search Jon Davis wrote: > .. add DISTINCT to that query (select distinct story_id ...) Or course > and don't > forget to escape the string delimiter to kill off sql injections That's a bad way to fend off sql injections. This is what bind params were built for. > select story_id from element >=20 > inner join story on element.root_id =3D story.element_id >=20 > where lower(data) like '%search text%' Seems reasonable with the above mentioned fixes. > If so, I'd like to request a feature. Please add a raw text content > search feature to the Find Stories -> Advanced view. This is a > much-needed feature that both editors and web devs (like me) need access > to so that we don't have to go poking around at mySql to find stories > that are in need of important fixes / edits, namely in our case our need > to track down all of the stories that have invalid e-mail address domain > names listed. I agree. This would be nice to have. What would be better though is full text searching on elements. Although that might be kind of hard since we have binary data in there too and full text searching is only on a limited number of column types. Maybe name this "Keyword" in the advanced screen? Would you mind adding it to the bug tracker as a feature request? http://bugzilla.krangcms.com/ Thanks for the request. --=20 Michael Peters Developer Plus Three, LP |