#9 Better display of album contents

closed-accepted
ace jones
None
5
2005-07-06
2005-06-16
Rob Walker
No

This patch changes the handling of albums to represent albums
as directories containing the files for each track. It also lists
albums as sub directories of each artist.

Discussion

  • Rob Walker
    Rob Walker
    2005-06-16

    Better display of album contents

     
  • ace jones
    ace jones
    2005-07-03

    Logged In: YES
    user_id=954547

    We still need to keep around an m3u-style file that lists
    the album's contents. I'll take a look to see how to
    accomplish this on top of this patch.

     
  • ace jones
    ace jones
    2005-07-03

    • assigned_to: nobody --> acejones
    • status: open --> pending-accepted
     
  • ace jones
    ace jones
    2005-07-05

    • status: pending-accepted --> open
     
  • ace jones
    ace jones
    2005-07-05

    Logged In: YES
    user_id=954547

    Ok, I do like this patch, but losing the text file of album
    contents is a feature regression. And it happens to be a
    feature I use myself.

    What would you think of adding a file in
    njb:/albums/AlbumName called
    njb:/albums/AlbumName/AlbumName.m3u that contains the data
    which was formerly generated by getAlbum()? Alternately, we
    could put the m3u file in just njb:/albums.

     
  • Rob Walker
    Rob Walker
    2005-07-05

    Logged In: YES
    user_id=31798

    I've reworked the patch to keep the text listing of the album as
    AlbumName.m3u in the album directory.

    A couple of issues remain though:
    - Reporting the size of the m3u as the total size of the album
    may not be a good idea - what if the client allocates a buffer or
    temporary storage based on that size, or expects to receive that
    many bytes.
    - We should match track names by artist and album where
    possible. It's likely that "Artist - Title" will produce more than one
    match if you have remix or live albums or tracks titled 'Intro'.

     
  • Rob Walker
    Rob Walker
    2005-07-05

    Revised album handling patch

     
  • ace jones
    ace jones
    2005-07-06

    Logged In: YES
    user_id=954547

    Thanks for the changes.

    > Reporting the size of the m3u as the total size of the
    album may not be a good idea

    Agree. It would be better to calculate the size of the m3u
    file itself.

    > It's likely that "Artist - Title" will produce more than
    one match

    Agree. I hate this about kionjb. Will copying files into
    njb:/albums alleviate this?

     
  • ace jones
    ace jones
    2005-07-06

    • status: open --> closed
     
  • ace jones
    ace jones
    2005-07-06

    • status: closed --> closed-accepted
     
  • ace jones
    ace jones
    2005-07-06

    Logged In: YES
    user_id=954547

    Ok, this is in. And I made the suggested change to report
    the size of the m3u file correctly.

    My only complaint is that deleting
    njb:/artists/MyArtistName/* is no longer supported, but it's
    only a minor complaint. I worked around it in the tests.