From: Martin Bartlett <martin.bartlett@cl...> - 2006-03-03 12:39:27
> Ok, Martin. I have this running now, thanks. I think this is all good
> However, there are some problems:
> - Breaking tree view is a show stopper. That's the main view I use in
> all of KDE. I wouldn't mind checking it in that way, if you had a fix
> on the way. But...
Well, the breaking of the tree view was directly due to adding a URL UDS
atom that has a directory portion that is not the same as the viewed
containing-directory (comment out the call to entry.append(atom) and
suddenly the tree works again).
So I changed the URL in my current version to be as follows:
njb:/<the pseudo directory>/<the track file name>.<the codec>#track<the
This works perfectly for both track copy where the track is named <track
file name>.<codec>, and for track playing via the m3u files, while
leaving a very logical detailed view etc (and makes for a much cleaner
fetch of the track id too). As you can see from the above format, the
declared directory for the track is now the same as the viewed
containing-directory. And ... it mends the tree view - voila! (I first
tried with a URL query string, but that did not fix it - for some reason
a reference string does!)
> - This patch requires a re-work of the tests. I can't really check it
> in as-is, because then the usefulness of the tests completely goes
> away. I'd recommend you get the tests working for you in a fresh
> checkout of CVS, and then make the needed changes in them to match the
> feature changes.
Test?? What is this word? An English word I have never heard? what does
it mean? (OK, noted, I'll get onto it!)
> - It crashes for me whenever I select View -> Show Details -> Show URL,
> in any directory.
In my KDE 3.4 there is no crash on viewing the URL - Maybe this is bug
in your KDE?
> - In the future, when changing njb.protocol, please make the same
> changes to njbt.protocol.
noted (I have added a "track position" field for album and playlist
ordering - another Konqueror anomaly is that numeric fields are not
allowed in the EXTRA UDS atoms, so these have to be ugly zero-padded
strings for now).
> Yes, copying tracks to the device uses a poor replacement mechanism.=20
> That would be a good thing to fix. Album and album position would solve
> most issues here, I think. =20
Definitely all thats really needed (and its better than the Dell DJ
manager that does not use album position!).
> The problem I think is in njb:/all. Can we have duplicate file names
When the Track ID is included in the URL, yes - another reason for
carrying the track ID in the URL.
> Refactoring the playlist as you described will mean having support for
> "Add" a directory in the playlists folder, right? And then you'd copy
> files into it from there. That all sounds quite good.
I have the viewing/playing side working, the addition side I have not
had time to work on yet.