Re: [Kile-devel] Review Request 124367: Replace QTabWidget by separate tabbar and stack.

[Michel L. <mic...@gm...>]

> On July 18, 2015, 2:46 p.m., Michel Ludwig wrote:
> > Hi Andreas,
> > 
> > unfortunately, I couldn't test this patch as it didn't apply cleanly. Could you check whether it is based against the latest master commit?
> 
> Andreas Cord-Landwehr wrote:
>     Hi Michel, strange, just tested and it works for me by applying with "git am" on the master branch.
>     Did you apply this review's request diff first and _then_ the 0001-Add-quick... patch afterwards?

Ok, now I got it :)

The patch looks quite good already.

It's a bit difficult to review it as it is in two parts. Here is one more comment:

There are lines like this in the patch:

m_tabDocuments->removeWidget(w);
m_tabDocuments->insertWidget(to, w);

Would it be possible to access m_tabDocuments only through View* pointers and not through indexes? Then the lines above could be removed.

Also, can you check what happens when two documents have the same file name (but a different path)? Thanks.


- Michel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124367/#review82615
-----------------------------------------------------------


On July 15, 2015, 7:17 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124367/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 7:17 p.m.)
> 
> 
> Review request for Kile.
> 
> 
> Repository: kile
> 
> 
> Description
> -------
> 
> Replace the former QTabWidget by a combination of QTabBar and QStackedWidget to make the interface more flexible.
> This is needed for the following review request for adding a quick access menu.
> 
> Seems I am unable to create a new review request that is based on this patch's hash. So for now I am appending the next patch in line to explain what I am up to do: Like in KDevelop the tab bar with all document names gains a small menu to access all currently open documents. That is usefull in particular, if you have many open documents at once/some documents open at once and the livepreview on, since in those cases the tab navigation is very slow to use.
> 
> 
> Diffs
> -----
> 
>   src/kile.cpp 8b5a40d 
>   src/kileviewmanager.h 7f7b87d 
>   src/kileviewmanager.cpp a112d29 
> 
> Diff: https://git.reviewboard.kde.org/r/124367/diff/
> 
> 
> Testing
> -------
> 
> manual testing.
> 
> 
> File Attachments
> ----------------
> 
> Patch for adding context menu with quick access to documents
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/15/0c297279-fcca-4a6f-a4aa-09d860ddbd7d__0001-Add-quick-access-menu-for-all-open-documents.patch
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>