This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106646/

Can you maybe check whether one can get rid of KileDocument::Info::lastModifiedFile altogether? It feels like such a function doesn't really belong in that class.
But having a 'lastModifiedFile' function in Utilities seems to make much more sense.

- Michel Ludwig


On November 11th, 2013, 9:40 p.m. UTC, Eugene Shalygin wrote:

Review request for Kile and Michel Ludwig.
By Eugene Shalygin.

Updated Nov. 11, 2013, 9:40 p.m.

Repository: kile

Description

Kind of addition to https://git.reviewboard.kde.org/r/106617/

This patch takes part of Info::lastModifiedFile() that works with file list, and splits it into  free function. The last one is called from Info::lastModifiedFile() and from LaTeX::updateBibs().
This allows updateBibs(true) to avoid implicit check of the master document.


Michel, seem like I forgot to add you to reviewers one year ago and you missed this review request. It is exceptional useful for LivePreview. Everytime I see my wife spending twice the time I do in waiting for LivePreview results, I recall this patch :)

Diffs

  • src/documentinfo.cpp (7ea3d6f)
  • src/kilestdtools.cpp (d68f9a8)
  • src/utilities.h (afb3af2)
  • src/utilities.cpp (9b73e6b)

View Diff