This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106646/

Sorry for the delay, but could you remind me again which problem this patch fixes?

src/utilities.cpp (Diff revision 1)
72
QString KileUtilities::lastModifiedFile(const QStringList& files, const QString& baseDir)
Hehe, this is a nice example of how to use encapsulated algorithms, but I'm afraid it makes the code almost unreadable...

Would you mind changing it a bit so that it becomes easier to understand again?

- Michel Ludwig


On October 8th, 2013, 12:58 a.m. UTC, Eugene Shalygin wrote:

Review request for Kile and Michel Ludwig.
By Eugene Shalygin.

Updated Oct. 8, 2013, 12:58 a.m.

Repository: kile

Description

Kind of addition to https://git.reviewboard.kde.org/r/106617/

This patch takes part of Info::lastModifiedFile() that works with file list, and splits it into  free function. The last one is called from Info::lastModifiedFile() and from LaTeX::updateBibs().
This allows updateBibs(true) to avoid implicit check of the master document.


Michel, seem like I forgot to add you to reviewers one year ago and you missed this review request. It is exceptional useful for LivePreview. Everytime I see my wife spending twice the time I do in waiting for LivePreview results, I recall this patch :)

Diffs

  • src/documentinfo.cpp (efdacdf)
  • src/utilities.h (afb3af2)
  • src/utilities.cpp (9b73e6b)

View Diff