This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109623/

On March 23rd, 2013, 5:24 p.m. UTC, Michel Ludwig wrote:

Ship It!

On March 23rd, 2013, 5:27 p.m. UTC, Michel Ludwig wrote:

Committed in b8a59d8eb6f311f5bcd4d39ac1951801900532e4.
Thank you!

- Eugene


On March 23rd, 2013, 1:20 a.m. UTC, Eugene Shalygin wrote:

Review request for Kile and Michel Ludwig.
By Eugene Shalygin.

Updated March 23, 2013, 1:20 a.m.

Description

I store my LaTeX sources in SCM and thus do not use dynamic line breaks. Because of that I want to use "Join lines" Kate function quite frequently. To do that one needs to select a paragraph and execute "Join lines". Thanks to the scripting for the current paragraph it is possible to write a script like:

view.selectParagraph()
document.joinLines()

and bind it to a key shortcut.
But it will not work as expected because selectParagraph() will include trailing EOL symbol, and join operation will join current paragraph with the next one. 

The patch adds a parameter to selectParagraph() function (in both scripting and EditorExtension) to specify do we want exact selection or whole-line selection. So the following script

view.selectParagraph(false)
document.joinLines()

does what is expected.

P.P.S. Perhaps the new behaviour (wholeLines = false) should be the default one in order to be executed from the Kile menu action also? At least I find it more logical.

Testing

Manual

Diffs

  • doc/scripting.docbook (9e87bee)
  • src/editorextension.h (e963129)
  • src/editorextension.cpp (fc3906b)
  • src/scripting/kilescriptview.h (b822c0f)
  • src/scripting/kilescriptview.cpp (bd875c7)

View Diff