This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106567/

Review request for Kile.
By Eugene Shalygin.

Updated Sept. 26, 2012, 9:04 p.m.

Changes

Identation fix-up. Sorry for the noise

Description

Kile shedules parsing of all projet items when it opens a project. But because Manager::m_projects does not contain currently loading project at that time, Manager can not resolve projet items to documents and parsing does not happen.

This patch adds curently parsing project to m_projects collection before invoking projectOpenItem() and thus parsing goes. In the next step, in Manager::handleParsingComplete(), TextInfo object is determined via opened documents list, as I understood. To install results for all project items, the patch adds a second branch that determines TextInfo object via KileProjectItem::getInfo() and the item is accessed via Manager::itemFor() (that is why project must be added to m_projects before parsing)

With these changes completion works for all bib items and labels in project even if these files are not opened.

However, project loading time increases significantly.

Testing

Manual testing

Diffs (updated)

  • src/parser/latexparser.cpp (ea0ae0b)
  • src/parser/parserthread.h (c41123b)
  • src/parser/parserthread.cpp (ad38819)
  • src/kiledocmanager.cpp (1d652c1)
  • src/documentinfo.cpp (2c3a3bb)
  • src/documentinfo.h (27ad09f)

View Diff