This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106363/

Ship it!

Ship It!

- Michel


On September 22nd, 2012, 11:32 a.m., Eugene Shalygin wrote:

Review request for Kile.
By Eugene Shalygin.

Updated Sept. 22, 2012, 11:32 a.m.

Description

As we can detect what backend is used by Biblatex only when it prints it out, we need to store that information for next updates of bibliography

This patch use dirty approach: it just stores this as dynamic property of TextInfo object and uses it afterwards. I believe we must store this information somewhere or parse \usepackage{biblatex}.
Maybe in the future Biblatex will provide some other setup commands for specifiyng backend which will be needed to parse also.
I understand, that dynamic property is not the best place to store it. From the other hand, it is kind of local information in this approach, because property name is not used outside.

Testing

Manual testing
Bugs: 268047

Diffs

  • src/data/kilestdtools-win.rc (647b2e1)
  • src/data/kilestdtools.rc (c3bf120)
  • src/documentinfo.h (27ad09f)
  • src/documentinfo.cpp (2c3a3bb)
  • src/kile.cpp (79320ca)
  • src/kileproject.h (e77035a)
  • src/kileproject.cpp (dd4087d)
  • src/kilestdtools.h (769e8ca)
  • src/kilestdtools.cpp (0c6e5f0)
  • src/kiletool.h (2b6c035)
  • src/kiletool.cpp (4e2fe8d)
  • src/kiletoolmanager.h (86e2258)
  • src/kiletoolmanager.cpp (d06e36f)
  • src/kileui.rc (e9f2b92)
  • src/livepreview.cpp (2ac3236)
  • src/outputinfo.h (096c708)
  • src/outputinfo.cpp (8d18adc)
  • src/widgets/toolconfigwidget.cpp (1845291)

View Diff