This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106363/

Review request for Kile.
By Eugene Shalygin.

Updated Sept. 9, 2012, 11:02 p.m.

Changes

Action added to build menu.
But I'm not happy with a few things in the patch.
1. String constants with tools names in LaTeXOutputHandler. Can I get these names from somewhere?
2. I do not know how to put KSelectAction into XMLGUI file. Is it possible?
3. Checks in the very beginning of KileTool::Manager::currentLaTeXOutputHandlerChanged. Would it be better to rearrange meny creation and event subscription? Or in any case one can expect a situation when menu does not exist?
4. KileProject::compilationSettingsConfigGroupName. Would be logical to use separate group. But then, LivePreview settings which are very similar, could also be in that group?
5. Just my private opinion (perhaps, casted by the using of IDEs) that user expects these settings in the project options, but not in the build menu. Personally I found LivePreview settings only after looking into the sources :)

Description

As we can detect what backend is used by Biblatex only when it prints it out, we need to store that information for next updates of bibliography

This patch use dirty approach: it just stores this as dynamic property of TextInfo object and uses it afterwards. I believe we must store this information somewhere or parse \usepackage{biblatex}.
Maybe in the future Biblatex will provide some other setup commands for specifiyng backend which will be needed to parse also.
I understand, that dynamic property is not the best place to store it. From the other hand, it is kind of local information in this approach, because property name is not used outside.

Testing

Manual testing
Bugs: 268047

Diffs (updated)

  • src/documentinfo.h (27ad09f)
  • src/documentinfo.cpp (2c3a3bb)
  • src/kile.cpp (8061b54)
  • src/kileproject.h (e77035a)
  • src/kileproject.cpp (dd4087d)
  • src/kilestdtools.h (769e8ca)
  • src/kilestdtools.cpp (0c6e5f0)
  • src/kiletoolmanager.h (86e2258)
  • src/kiletoolmanager.cpp (d06e36f)
  • src/outputinfo.h (096c708)
  • src/outputinfo.cpp (8d18adc)

View Diff