|This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106363/|
Thanks! I'd also suggest to give the user the power to override our bib tool detection by adding a new entry to the "Build" menu with a submenu that would allow to choose between "auto-detect", "BibTeX", or "Biblatex" (similar to the "Live Preview" entry). The chosen settings could then be stored in LaTeXOutputHandler as well (which might also need a new name now as it refers to pre-compilation settings as well then :)
|src/documentinfo.h (Diff revision 3)|
virtual QString readBibliographyBackendToolName(const QString& defaultValue) const;
Could you leave the methods 'public' here?
|src/outputinfo.h (Diff revision 3)|
class LatexOutputInfo : public OutputInfo
virtual void writeBibliographyBackendToolName(const QString& toolName) = 0;
Just to keep the naming convention: writeBibliographyBack... -> setBibliographyBackendToolName readBibliographyBack... -> bibliographyBackendToolName()
On September 7th, 2012, 10:14 p.m., Eugene Shalygin wrote:
Review request for Kile.
By Eugene Shalygin.
Updated Sept. 7, 2012, 10:14 p.m.