#24 ESC causes window destruction (bad)

closed
nobody
5
2010-01-30
2010-01-24
Anonymous
No

The world editor dialog does not display again if you hit ESC in Ubuntu instead of clicking the Cancel button. The ESC key causes the window widget to be destroyed. Since the window widget is stored on the world object and there is no signal response for window destruction, kildclient never realizes that the window is destroyed other than to emit GTK errors.

Here is a patch for 2.9.0 that fixes the problem:

--- worldeditor.c.orig 2010-01-24 14:21:53.000000000 -0600
+++ worldeditor.c.new 2010-01-24 14:20:25.000000000 -0600
@@ -138,6 +138,10 @@
editor is closed, the main window gets focus. */
}
}
+ else if (response == GTK_RESPONSE_DELETE_EVENT) {
+ world->dlgEditWorld = NULL;
+ return;
+ }

gtk_widget_hide(dialog);
}

Discussion

  • This had been fixed already in the SVN. The fill will appear in the next version.

     
    • status: open --> closed