Re: [Kernow] DirectoryTransformer.runDirectoryTransform() on "not a directory"

[Andrew W. <and...@gm...>]

On 8/6/07, Florent Georges <dar...@ya...> wrote:
> Andrew Welch wrote:
>
> > You guess correct, it should return false.
>
>   Ok, this is a little bug in runDirectoryTransform().  I suggest to
> change:
>
>     if (children == null) {
>         Message.error("Input XML directory is either not a directory or
> not there: " + xmlDir.getAbsolutePath());
>     } else {
>
> to:
>
>     if (children == null) {
>         Message.error("Input XML directory is either not a directory or
> not there: " + xmlDir.getAbsolutePath());
>         overallSuccess = false;
>     } else {
>
>   Do I commit it?

Yes please - you probably could add:

progressText = "Error";

which will be displayed where the time normally goes.

-- 
http://andrewjwelch.com